Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate from TypeScript 4.9 to 5.2 #5233

Merged
merged 2 commits into from
Dec 27, 2023
Merged

chore: Migrate from TypeScript 4.9 to 5.2 #5233

merged 2 commits into from
Dec 27, 2023

Conversation

lachlancollins
Copy link
Member

An incremental step to bringing the workspace config more in line with TanStack Query. TS version is pinned so it doesn't auto update (TS doesn't use semantic versioning).

@lachlancollins lachlancollins changed the title chore: Migrate from TS v4.9 to c5.2 chore: Migrate from TypeScript v4.9 to c5.2 Dec 27, 2023
@lachlancollins lachlancollins changed the title chore: Migrate from TypeScript v4.9 to c5.2 chore: Migrate from TypeScript 4.9 to 5.2 Dec 27, 2023
@KevinVandy
Copy link
Member

Does the project still build after this? Last time I tried this a few months ago, there was some roll-up incompatibility

@lachlancollins
Copy link
Member Author

Does the project still build after this? Last time I tried this a few months ago, there was some roll-up incompatibility

I tested yarn run pr locally (and it also seemed to work on CI). Do you know what was breaking?

@KevinVandy
Copy link
Member

@lachlancollins checked out your PR and yarn build is still fine. Don't remember what I ran into a few months ago.

I ran npx npm-check-updates -u -ws --root typescript to update to version 5.3.3 though and had the same success, so might as well upgrade to the latest

@KevinVandy KevinVandy merged commit f7b7a8e into TanStack:main Dec 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants