feat(angular-table): Support Tanstack v9 alpha and Angular 19, fix examples #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5125947. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
KevinVandy
reviewed
Nov 24, 2024
| @@ -39,10 +39,10 @@ import type { Column, Table } from '@tanstack/angular-table' | |||
| standalone: true, | |||
| imports: [CommonModule], | |||
| }) | |||
| export class FilterComponent<T> implements OnInit { | |||
| export class FilterComponent<T extends RowData> implements OnInit { | |||
There was a problem hiding this comment.
Might be changing these generics to include TFeatures since it effects what APIs can be used in the logic of this component.
KevinVandy
reviewed
Nov 24, 2024
| createColumnHelper, | ||
| features: tableHelperOptions._features, | ||
| options: _tableHelperOptions as any, | ||
| tableCreator: (tableOptions) => |
There was a problem hiding this comment.
If this is the only difference, we might explore just making some TS overloads and an option for how it needs to work for Angular in the table-core constructTableHelper function. Good to be here for now.
KevinVandy
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating the Angular adapter and related examples to support the new helpers and
_featuresproperty. It's mostly finished, but here's some points:injectTable types
Due to the new TableOptions types, I've seen that there are some typescript issues while passing the _rowModels property, probably since we pass a function as an argument and _rowModels is using
NoInfer:/The error
Overriding the properties in that way seems resolving the issue, but could there be some contraindications doing this? Would it make sense to have a less strict type?
constructTableHelper/createTableHelper
Since we need to pass a
functionas an argument to theinjectTable/createAngularTablefn, I think for Angular we should have our own implementation of the core "constructTableHelper" function.In the future we might need to update this function to be invoked within the context of the angular app, for example if we need to create the helper as a constant and still allowing to inject data/options from a token or service.
I've then added a
constructTableHelper.tsfile the updated signature. This helper is used internally bycreateTableHelper, which is exported publicly.Continue on #5816 for the new proxy implementation