Merge pull request #4 from TappNetwork/getById

getById instead of email
TappNetwork · Oct 25, 2024 · 965340f · 965340f
2 parents 67c2c85 + a5345c7
commit 965340f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/LaravelHubspotServiceProvider.php b/src/LaravelHubspotServiceProvider.php
@@ -32,7 +32,7 @@ public function bootingPackage()
     {
         $this->app->bind(LaravelHubspot::class, function ($app) {
 
-            $stack = new HandlerStack();
+            $stack = new HandlerStack;
             $stack->setHandler(Utils::chooseHandler());
 
             $stack->push(Middleware::mapRequest(function (RequestInterface $r) {

diff --git a/src/Models/HubspotContact.php b/src/Models/HubspotContact.php
@@ -76,14 +76,13 @@ public static function updateOrCreateHubspotContact($model)
         // }
 
         try {
-            // TODO get by ID is unreliable (404 with api but works with web UI)
-            // if ($model->hubspot_id) {
-            // $hubspotContact = Hubspot::crm()->contacts()->basicApi()->getById($model->hubspot_id, null, null, null, false, 'id');
-            // } else {
-            $hubspotContact = Hubspot::crm()->contacts()->basicApi()->getById($model->email, null, null, null, false, 'email');
+            if ($model->hubspot_id) {
+                $hubspotContact = Hubspot::crm()->contacts()->basicApi()->getById($model->hubspot_id);
+            } else {
+                $hubspotContact = Hubspot::crm()->contacts()->basicApi()->getById($model->email, null, null, null, false, 'email');
 
-            $model->hubspot_id = $hubspotContact['id'];
-            // }
+                $model->hubspot_id = $hubspotContact['id'];
+            }
         } catch (ApiException $e) {
             // catch 404 error
             Log::debug('Hubspot contact not found. Creating', ['email' => $model->email]);