Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Laravel 11 and Use env() for dynamic configuration #29

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Support Laravel 11 and Use env() for dynamic configuration #29

merged 3 commits into from
Jul 24, 2024

Conversation

shonggeok
Copy link
Contributor

No description provided.

@swilla
Copy link
Member

swilla commented Jul 22, 2024

Can you fix StyleCI?

@shonggeok
Copy link
Contributor Author

Can you fix StyleCI?

Hi, could you please check again? Thanks!

swilla
swilla requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@swilla swilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, can you update the readme with the dynamic config details and this will be ready to merge.

@shonggeok
Copy link
Contributor Author

This looks good, can you update the readme with the dynamic config details and this will be ready to merge.

Thanks for reviewing the changes. I've updated README with dynamic config details. Please review again!

@swilla swilla merged commit c5a779a into TappNetwork:master Jul 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilla swilla swilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shonggeok @swilla