-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Implement shows sync using episodes #1578
Conversation
Actually for me the syncing is even slower:
reason being is that extra api calls are still there:
|
ef93d07
to
92efa44
Compare
timing again:
So, the new code is actually slower for me. |
I think the slowdown is because it is now querying Trakt for every episode since it doesn't create the It's faster on the Plex side, but slower on the Trakt side. |
I haven't verified this, but I think it's also slower now because needs to fetch every plex show separately. can probably can be solved by batching show fetches as well. |
8651363
to
75cad0a
Compare
Added plex shows preloading and caching show object for next episode of same show. Timing looks promising. scanning a library with 227 shows, 5180 episodes with hot cache. the library is mostly healthy (few missing matches) and using legacy agent. there's also bunch of reloading episode/show for year and userRating, that slows down as well.
|
I'll go on with merge then |
Tested successfully.
|
it's preloading tvshows in first run. do you have recommendations for it? make it silent? change display? also, it's processing fast the first round right? can you also post your timings of now and then? |
what is the difference? if you made code changes so just submit them? |
Created new issue: I stopped using email notifications, so I won't see activity in closed pull requests. Would need to specifically look at closed pull requests and order by activity date. |
Implement shows sync using episodes search:
Requires support from PlexApi side: - pkkid/python-plexapi#1243Fixes #976