test: (#281) Response Test 제거

Team-ComIT · Jan 11, 2023 · 90a35b6 · 90a35b6
1 parent 205b81a
commit 90a35b6
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 93 deletions.
diff --git a/...st/kotlin/team/comit/simtong/domain/holiday/usecase/QueryIndividualHolidayUseCaseTests.kt b/...st/kotlin/team/comit/simtong/domain/holiday/usecase/QueryIndividualHolidayUseCaseTests.kt
@@ -5,8 +5,6 @@ import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 import org.mockito.kotlin.given
 import org.springframework.boot.test.mock.mockito.MockBean
-import team.comit.simtong.domain.holiday.dto.IndividualHolidayResponse
-import team.comit.simtong.domain.holiday.dto.QueryIndividualHolidaysResponse
 import team.comit.simtong.domain.holiday.dto.QueryIndividualRequest
 import team.comit.simtong.domain.holiday.model.Holiday
 import team.comit.simtong.domain.holiday.model.value.HolidayStatus
@@ -34,7 +32,7 @@ class QueryIndividualHolidayUseCaseTests {
  QueryIndividualRequest(
  startAt = LocalDate.now(),
  endAt = LocalDate.now(),
- status = HolidayStatus.COMPLETED.name
+ status = HolidayStatus.COMPLETED
  )
  }
 
@@ -50,17 +48,6 @@ class QueryIndividualHolidayUseCaseTests {
  )
  }
 
- private val responseStub : QueryIndividualHolidaysResponse by lazy {
- QueryIndividualHolidaysResponse(
- holidaysStub.map {
- IndividualHolidayResponse(
- date = it.date,
- type = it.type.name
- )
- }
- )
- }
-
  @BeforeEach
  fun setUp() {
  queryIndividualHolidayUseCase = QueryIndividualHolidayUseCase(
@@ -79,10 +66,10 @@ class QueryIndividualHolidayUseCaseTests {
  .willReturn(holidaysStub)
 
  // when
- val response = queryIndividualHolidayUseCase.execute(requestStub)
+ val result = queryIndividualHolidayUseCase.execute(requestStub)
 
  // then
- assertEquals(response, responseStub)
+ assertEquals(result, holidaysStub)
  }
 
 }
diff --git a/.../kotlin/team/comit/simtong/domain/schedule/usecase/QueryEntireSpotScheduleUseCaseTests.kt b/.../kotlin/team/comit/simtong/domain/schedule/usecase/QueryEntireSpotScheduleUseCaseTests.kt
@@ -5,8 +5,6 @@ import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 import org.mockito.kotlin.given
 import org.springframework.boot.test.mock.mockito.MockBean
-import team.comit.simtong.domain.schedule.dto.QueryEntireSpotScheduleResponse
-import team.comit.simtong.domain.schedule.dto.SpotScheduleResponse
 import team.comit.simtong.domain.schedule.model.value.Scope
 import team.comit.simtong.domain.schedule.spi.QuerySchedulePort
 import team.comit.simtong.domain.schedule.spi.vo.SpotSchedule
@@ -37,23 +35,6 @@ class QueryEntireSpotScheduleUseCaseTests {
  )
  )
 
- private val responseStub: QueryEntireSpotScheduleResponse by lazy {
- QueryEntireSpotScheduleResponse(
- listOf(
- SpotScheduleResponse(
- id = uuid,
- startAt = date,
- endAt = date,
- title = "test title",
- spot = SpotScheduleResponse.SpotElement(
- id = uuid,
- name = "test name"
- )
- )
- )
- )
- }
-
  @BeforeEach
  fun setUp() {
  queryEntireSpotScheduleUseCase = QueryEntireSpotScheduleUseCase(querySchedulePort)
@@ -66,10 +47,10 @@ class QueryEntireSpotScheduleUseCaseTests {
  .willReturn(spotScheduleListStub)
 
  // when
- val response = queryEntireSpotScheduleUseCase.execute(date, date)
+ val result = queryEntireSpotScheduleUseCase.execute(date, date)
 
  // then
- assertEquals(response, responseStub)
+ assertEquals(result, spotScheduleListStub)
  }
 
 }
diff --git a/...lin/team/comit/simtong/domain/schedule/usecase/QueryIndividualSpotScheduleUseCaseTests.kt b/...lin/team/comit/simtong/domain/schedule/usecase/QueryIndividualSpotScheduleUseCaseTests.kt
@@ -1,21 +1,19 @@
 package team.comit.simtong.domain.schedule.usecase
 
-import org.assertj.core.api.Assertions.assertThat
+import org.junit.jupiter.api.Assertions.assertEquals
 import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.assertThrows
 import org.mockito.kotlin.given
 import org.springframework.boot.test.mock.mockito.MockBean
-import team.comit.simtong.domain.schedule.dto.QueryIndividualSpotScheduleResponse
-import team.comit.simtong.domain.schedule.dto.ScheduleResponse
 import team.comit.simtong.domain.schedule.model.Schedule
 import team.comit.simtong.domain.schedule.model.value.Scope
 import team.comit.simtong.domain.schedule.spi.QuerySchedulePort
 import team.comit.simtong.domain.schedule.spi.ScheduleQueryUserPort
 import team.comit.simtong.domain.schedule.spi.ScheduleSecurityPort
 import team.comit.simtong.domain.user.exception.UserExceptions
-import team.comit.simtong.domain.user.model.value.Authority
 import team.comit.simtong.domain.user.model.User
+import team.comit.simtong.domain.user.model.value.Authority
 import team.comit.simtong.global.annotation.SimtongTest
 import java.time.LocalDate
 import java.util.UUID
@@ -87,27 +85,6 @@ class QueryIndividualSpotScheduleUseCaseTests {
  )
  }
 
- private val responseStub by lazy {
- QueryIndividualSpotScheduleResponse(
- listOf(
- ScheduleResponse(
- id = scheduleId,
- startAt = minDate,
- endAt = minDate,
- title = "test title",
- scope = Scope.INDIVIDUAL
- ),
- ScheduleResponse(
- id = scheduleId,
- startAt = maxDate,
- endAt = maxDate,
- title = "test title",
- Scope.ENTIRE
- )
- )
- )
- }
-
  @BeforeEach
  fun setUp() {
  queryIndividualSpotScheduleUseCase = QueryIndividualSpotScheduleUseCase(
@@ -135,10 +112,10 @@ class QueryIndividualSpotScheduleUseCaseTests {
  )
 
  // when
- val response = queryIndividualSpotScheduleUseCase.execute(date, date)
+ val result = queryIndividualSpotScheduleUseCase.execute(date, date)
 
  // then
- assertThat(response).isEqualTo(responseStub)
+ assertEquals(result, listOf(individualScheduleStub, entireScheduleStub).sortedBy(Schedule::startAt))
  }
 
  @Test

diff --git a/...cation/src/test/kotlin/team/comit/simtong/domain/spot/usecase/ShowSpotListUseCaseTests.kt b/...cation/src/test/kotlin/team/comit/simtong/domain/spot/usecase/ShowSpotListUseCaseTests.kt
@@ -5,7 +5,6 @@ import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 import org.mockito.BDDMockito.given
 import org.springframework.boot.test.mock.mockito.MockBean
-import team.comit.simtong.domain.spot.dto.SpotResponse
 import team.comit.simtong.domain.spot.model.Spot
 import team.comit.simtong.domain.spot.spi.QuerySpotPort
 import team.comit.simtong.global.annotation.SimtongTest
@@ -35,18 +34,6 @@ class ShowSpotListUseCaseTests {
  )
  }
 
- private val responseStub: SpotResponse by lazy {
- SpotResponse(
- listOf(
- SpotResponse.SpotElement(
- id = id,
- name = name,
- location = location
- )
- )
- )
- }
-
  @BeforeEach
  fun setUp() {
  showSpotListUseCase = ShowSpotListUseCase(querySpotPort)
@@ -58,8 +45,11 @@ class ShowSpotListUseCaseTests {
  given(querySpotPort.queryAllSpot())
  .willReturn(spotListStub)
 
- // when & then
- assertEquals(showSpotListUseCase.execute(), responseStub)
+ // when
+ val result = showSpotListUseCase.execute()
+
+ // then
+ assertEquals(result, spotListStub)
  }
 
 }
diff --git a/...lication/src/test/kotlin/team/comit/simtong/domain/team.usecase/QueryTeamsUseCaseTests.kt b/...lication/src/test/kotlin/team/comit/simtong/domain/team.usecase/QueryTeamsUseCaseTests.kt
@@ -5,7 +5,6 @@ import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 import org.mockito.BDDMockito.given
 import org.springframework.boot.test.mock.mockito.MockBean
-import team.comit.simtong.domain.team.dto.QueryTeamsResponse
 import team.comit.simtong.domain.team.model.Team
 import team.comit.simtong.domain.team.spi.QueryTeamPort
 import team.comit.simtong.global.annotation.SimtongTest
@@ -33,17 +32,6 @@ class QueryTeamsUseCaseTests {
  )
  }
 
- private val responseStub: QueryTeamsResponse by lazy {
- QueryTeamsResponse(
- listOf(
- QueryTeamsResponse.TeamElement(
- id = id,
- name = name
- )
- )
- )
- }
-
  @BeforeEach
  fun setUp() {
  queryTeamsUseCase = QueryTeamsUseCase(queryTeamPort)
@@ -56,10 +44,10 @@ class QueryTeamsUseCaseTests {
  .willReturn(teamsStub)
 
  // when
- val response = queryTeamsUseCase.execute(spotId)
+ val result = queryTeamsUseCase.execute(spotId)
 
  // then
- assertEquals(response, responseStub)
+ assertEquals(result, teamsStub)
  }
 
 }