[feat] DB 타임존을 한국 시간으로 변경 #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seohyun-106
added
🍀 feature
geeneve
reviewed
Oct 13, 2022
| @@ -0,0 +1,7 @@ | |||
| const KOREA_TIME_DIFFERENCE: number = 9 * 60 * 60 * 1000; | |||
There was a problem hiding this comment.
요즘 클린코드책으로 수업 듣는다더니 장난 없네요 ? 🧐🧐
geeneve
reviewed
Oct 13, 2022
| const KOREA_TIME_DIFFERENCE: number = 9 * 60 * 60 * 1000; | ||
|
|
||
| export const convertTimeZone = (currentTime: number): Date => { | ||
| let newTime: number = currentTime + KOREA_TIME_DIFFERENCE; |
holmir97
approved these changes
Oct 14, 2022
| @@ -0,0 +1,7 @@ | |||
| const KOREA_TIME_DIFFERENCE: number = 9 * 60 * 60 * 1000; | |||
There was a problem hiding this comment.
오오 코딩 표준 👍👍 주석으로 정확히 얼마 정도의 시간인지 달아주면 좋을 것 같아여
ex) 9h, 10m, 100s 등등
|
|
||
| export const convertTimeZone = (currentTime: number): Date => { | ||
| let newTime: number = currentTime + KOREA_TIME_DIFFERENCE; | ||
| let newDate: Date = new Date(newTime); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈 PR 요약 / Linked Issue
DB 타임스탬프에 UTC로 저장되던 것을 한국 시간으로 변경했습니다
close #128
📌 변경 사항
✅ PR check list
1. 제목 양식 준수 확인
[feat] PR title
2. 테스트 코드 작동 스크린샷
npm run mocha✅ After merge check list
1. 릴리즈 노트 변경
릴리즈 노트 To Do에서 Done으로 옮기기
2. 브랜치 삭제