Add link to donation page on app drawer #11870
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
requested changes
Jan 2, 2025
Comment on lines
+937
to
+941
| private void openDonationPage() { | ||
| final Intent intent = new Intent(Intent.ACTION_VIEW, | ||
| Uri.parse(getString(R.string.donation_url))); | ||
| startActivity(intent); | ||
| } |
There was a problem hiding this comment.
Use ShareUtils to create and start the intent.
AudricV
changed the title
AudricV
added
the
template missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At 38c3 we discussed how we could make the request for donations more visible. We discussed multiple models. Ultimately we could not agree on a good solution to actually ask the user for donations.
However, we all agreed that donations should be more visible than just show up in the about screen.
This will add the link for donations to the app drawer. When clicking it will open the donation page of the NewPipe website.