Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement oidc #628

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Implement oidc #628

wants to merge 18 commits into from

Conversation

Jeidnx
Copy link

@Jeidnx Jeidnx commented Jun 18, 2023

Copy link
Member

@FireMasterK FireMasterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I don't like is there's too much business logic in ServerLaunche, I would ideally like to move it to a new file like OidcHandlers.java or to the existing UserHandlers class.

@Jeidnx
Copy link
Author

Jeidnx commented Nov 12, 2024

I have cleaned up the code and made sure everything works. Here are a few things worth mentioning:

  • This only supports providers which have the openid connect discovery standard (.well-known/openid-configuration) implemented, which should be all relevant providers.
  • User deletion currently only works if the provider supports the optional max_age parameter and properly returns the auth_time claim. We could drop this restriction, but that would allow one-click deletion of accounts without verifying the identity of the user.
  • This also only works with providers which support the PKCE code authorization flow, which again should be most of them.

Please let me know if there are any questions or concerns. I have tested this and from my view this could be merged

edit: Found the alternative for TokenRequest..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants