-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement oidc #628
base: master
Are you sure you want to change the base?
Implement oidc #628
Conversation
# Conflicts: # build.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I don't like is there's too much business logic in ServerLaunche
, I would ideally like to move it to a new file like OidcHandlers.java
or to the existing UserHandlers
class.
I have cleaned up the code and made sure everything works. Here are a few things worth mentioning:
Please let me know if there are any questions or concerns. I have tested this and from my view this could be merged edit: Found the alternative for |
see TeamPiped/Piped#2571