Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visibility, license and tags to streams info #661

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

Bnyro
Copy link
Member

@Bnyro Bnyro commented Jul 28, 2023

They could all be well displayed in the description next to the category, so I think it makes sense to add them.
At least for LibreTube, the iso code for the video's language can be parsed to a translated string, that's why the language code would be useful as well in my eyes.

Copy link
Member

@FireMasterK FireMasterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge if tests pass after you fix the current build issues.

src/main/java/me/kavin/piped/utils/CollectionUtils.java Outdated Show resolved Hide resolved
@Bnyro
Copy link
Member Author

Bnyro commented Jul 28, 2023

reminder: PR needs to be squashed when merging because I was too lazy to squash my changes

@FireMasterK
Copy link
Member

You could just amend your existing commit and force push it. It's a lot easier if you ask me :)

@Bnyro
Copy link
Member Author

Bnyro commented Jul 28, 2023

That's what I do when I'm on my PC.
However, that's not possible when using the web ui from github on my phone :p

@Bnyro
Copy link
Member Author

Bnyro commented Jul 28, 2023

Just wanted to quickly look whether the checks would pass

@Bnyro Bnyro changed the title add language, license and tags to streams info add visibility, license and tags to streams info Jul 29, 2023
@Bnyro Bnyro merged commit dc0d566 into TeamPiped:master Jul 29, 2023
17 checks passed
@Bnyro Bnyro deleted the additional-streams-info branch July 29, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants