impl registrationDisabled into NavBar #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FireMasterK
approved these changes
Jul 14, 2023
Bnyro
reviewed
Jul 14, 2023
| @@ -185,6 +190,11 @@ export default { | |||
| onSearchTextChange(searchText) { | |||
| this.searchText = searchText; | |||
| }, | |||
| async fetchAuthConfig() { | |||
| this.fetchJson(this.authApiUrl() + "/config").then(config => { | |||
| this.registrationDisabled = config?.registrationDisabled === true; | |||
There was a problem hiding this comment.
I don't really like this because the config will now be fetched twice on each lagd reload, since the footer component does the same in order to receive the URLs in the footer.
There was a problem hiding this comment.
Me too, but I thought this was okay since we're fetching the configuration of the authentication API. We need to make a universal way of loading it for the oidc PR too.
There was a problem hiding this comment.
I was also thinking of loading the config and caching it somewhere so it does not have to be loaded twice if authApi = api but i thought this might be out-of-scope for this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Register" button will now only show when it is enabled on the server.
Because of the async delay when fetching the configuration from the server, it will show the "Register" button for a short period of time until the data is loaded.
Side Note
Servers without the newest version (TeamPiped/Piped-Backend#645) will still show the button.