Revert "chore: updated to HAproxy 3.0 and forced running as root"

[proudier]

Reverts #130

Given the issue #132 and the lack of activity on haproxy/haproxy#2684, let's revert this PR

@pedrobaeza @josep-tecnativa

[josep-tecnativa]

Perhaps it needs to be updated with the command poetry update so that the checks pass successfully.

[josep-tecnativa]

ping @proudier

[proudier]

(sorry for the delay)

Issue with the test suite

I think there is an issue with the test suite. I ran it 40 times on my machine and all the runs passed (see script below). Also, this MR reverts 100% of the original MR (#130), so anything #130 might have broken would be unbroken...

I ran the same script against v1.2.0: 10 out of 40 runs passed. It should be either 0 or 40. Moreover, it's not always the same test that fails, and sometimes more than one test fails. This randomness tends to confirm we have an issue with the test suite.

Error analysis

The errors reported by the failed tests are of two types, similar to those:

• error during connect: Get "http://localhost:49350/v1.47/version": read tcp [::1]:62552->[::1]:49350: read: connection reset by peer
• error during connect: Get "http://localhost:49364/v1.47/version": EOF

My guess is that the "docker create" (in proxy_factory) returns before the container is actually available on the network. After all, many software components are involved: docker daemon, {ip,nft}tables, linux bridge, ...

Proposal

I ran the script against v1.2.0 with a change in conftest.py: a pause after the creation of the container -> All runs passed (used to be 10 out of 40)!

Im aware a hardcoded pause in a test suite is not an elegant approach but

• the test suite is still prety fast (4.6 sec on average with the pause)
• having a flaky test suite is horrible
• fixing the docker daemon is waaaay out of scope
• it's easy to revert if/when someone has a better approach

Next steps

What do you think about all this?

I could send a new MR with the sleep fix (+poetry deps update while at it) and rebase this MR once it's former is merged

Test script

# gitref=7caf185
# 7caf185 is the revert MR, with no poetry update

# Preparation
# !!!! BEWARE of the `docker system prune` !!!!
git reset --hard $gitref
poetry install --no-root
docker rmi test:docker-socket-proxy
docker system prune -f

# Run 40 test passes
for i in {1..40}; do
    poetry run pytest --prebuild > "$gitref-test-output-$i"
    sleep 2
done

successes=$(grep '4 passed' $gitref-test-output-* | wc -l)

[josep-tecnativa]

It's OK for me.

[josep-tecnativa]

Now we can merge this @pedrobaeza