Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates HAProxy to the 2.2-alpine tag #30

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Updates HAProxy to the 2.2-alpine tag #30

merged 1 commit into from
Apr 15, 2021

Conversation

stumpylog
Copy link
Contributor

@stumpylog stumpylog commented Sep 25, 2020

Updates the underlying HAProxy to the 2.2-alpine, which fixes #28 and closes #29 and closes #49. It goes a bit less far than GH-29

@yajo yajo self-assigned this Sep 29, 2020
@yajo
Copy link
Contributor

yajo commented Sep 29, 2020

I'll add some small tests before merging, just to be sure this works as expected and to be able to merge things faster.

Sorry for the long wait and thanks for the contribution.

@pascalandy
Copy link

following big time!

@SuperSandro2000
Copy link

Bump?

@yajo
Copy link
Contributor

yajo commented Apr 12, 2021

This is quite outdated. Please rebase and fix conflicts.

@SuperSandro2000
Copy link

This is a single line fix. Not like it could be cherry picked into master.

@yajo
Copy link
Contributor

yajo commented Apr 13, 2021

I don't think the same:

  1. It's not a fix because we have no bug there.
  2. And this "single line" changes all the underlying docker image.
  3. And in this time that has passed, we have set in place a test suite that would make me comfortable of merging it.

So, please rebase.

Otherwise, somebody could open a new PR superseding this one, which seems stale 🤷🏼‍♂️

@SuperSandro2000
Copy link

I have opened #49.

@stumpylog
Copy link
Contributor Author

I found some time to rebase and fix the conflicts

@yajo yajo added this to the 0.1.2 milestone Apr 15, 2021
@yajo
Copy link
Contributor

yajo commented Apr 15, 2021

Thanks! The tests seem happy, so I'll merge.

@yajo yajo merged commit 0ae2b3e into Tecnativa:master Apr 15, 2021
@yfhyou
Copy link

yfhyou commented Apr 22, 2024

Did anyone come across this issue when testing this PR? #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to HAProxy 2?
5 participants