docs: unbreak RTD and fix GitHub CI #488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tox v4, "reuse of environments" was disabled [1]. This is then later explained [2] to refer to exactly that thing which we were using for inheriting the dependencies from the top-level testenv all the way to the docs build. That's why the docs build in GitHub CI started failing. [1] https://tox.wiki/en/4.11.4/upgrading.html#reuse-of-environments [2] https://tox.wiki/en/4.11.4/upgrading.html#packaging-configuration-and-inheritance Change-Id: I26378d55751f6719a6daee1cdcc57563243c1b01
jktjkt
force-pushed
the
wip/docs
branch
2 times, most recently
from
3f38fe9 to
303a579
Compare
Now that the top-level `tox` inheritance is fixed, there's no need to repeat the dependencies across several files. We're going to require a newer Sphinx because some automagic version deps bring sphinxcontrib-applehelp which now requires Sphinx v5. While we're at it, let's bring this to Sphinx v7. This required that `lang` change (changed in v5). Of course, because of the version pinning hell, Sphinx v7 requires newer myst-parser, so let's be bold and go all the way to v2. What could possibly go wrong? This (partially) reverts commit 47c8962. Change-Id: Ie60ed866b14ac7ac424ea2cea05c99d0f996f854
jktjkt
changed the title
It was failing with a message: Config validation error in build.os. Value os not found. Apparently, the v2 config file is mandatory, so let's do that. Change-Id: I267d5314db026de532b2b6644f500d25de08e343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.