Fix the inconsistency issue of LZ4 performance across different hardware during autotest. #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hparty
force-pushed
the
bugfix/diskcachetest
branch
from
c1d9ab3
to
ec2291f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2473 +/- ##
==========================================
- Coverage 77.39% 77.33% -0.06%
==========================================
Files 420 420
Lines 22468 22456 -12
Branches 6321 6353 +32
==========================================
- Hits 17388 17367 -21
- Misses 3817 3818 +1
- Partials 1263 1271 +8 ☔ View full report in Codecov by Sentry. |
domchen
reviewed
Sep 14, 2024
domchen
reviewed
Sep 14, 2024
CMakeLists.txt
Outdated
| @@ -53,8 +53,10 @@ endif () | |||
|
|
|||
| if (MACOS OR IOS) | |||
| option(PAG_BUILD_FRAMEWORK "Allow build framework" ON) | |||
| set(PAG_USE_SYSTEM_LZ4 ON) | |||
There was a problem hiding this comment.
你要加的是Option默认值，不能是Set，否则外部传入的就被你覆盖了。
domchen
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the inconsistency issue of LZ4 performance across different hardware during autotest.