Fix the deadlock issue when onSurfaceCreated is called after setting Sync in PAGView #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hparty
commented
Sep 25, 2024
| @@ -874,7 +874,6 @@ void JPAGView::onSurfaceCreated(NativeWindow* window) { | |||
| return; | |||
| } | |||
| player->setSurface(pag::PAGSurface::MakeFrom(drawable)); | |||
| animator->update(); | |||
There was a problem hiding this comment.
animator update时会使用JPAGView上的锁，导致onSurfaceCreated和update死锁了。把animator->update()逻辑放在ts层，这样两个地方就不会同时请求一个锁了
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2498 +/- ##
==========================================
+ Coverage 77.42% 77.44% +0.02%
==========================================
Files 420 420
Lines 22456 22456
Branches 6310 6315 +5
==========================================
+ Hits 17386 17391 +5
+ Misses 3814 3813 -1
+ Partials 1256 1252 -4 ☔ View full report in Codecov by Sentry. |
…uced by the latest IDE in HarmonyOS.
domchen
approved these changes
Sep 25, 2024
kevingpqi123
added a commit
that referenced
this pull request
Sep 26, 2024
…Sync in PAGView (#2498) Co-authored-by: kevingpqi <kevingpqi@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.