refactor(popup): sfc to tsx #1401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
betavs
force-pushed
the
feature/popup-to-tsx
branch
from
98f0848
to
11980ed
Compare
anlyyao
reviewed
Jun 6, 2024
src/popup/popup.tsx
Outdated
| @@ -31,21 +17,25 @@ let lockTimes = 0; | |||
|
|
|||
| export default defineComponent({ | |||
| name, | |||
| components: { TNode, TOverlay }, | |||
| inheritAttrs: false, | |||
| props: popupProps, | |||
There was a problem hiding this comment.
import props from './props';
这里简写～
|
test 挂了，有空继续关注一下哦～ |
|
@anlyyao 功能没有问题，不止 |
liweijie0812
reviewed
Aug 1, 2024
betavs
force-pushed
the
feature/popup-to-tsx
branch
from
cb5832b
to
f31b365
Compare
|
/update-snapshot |
|
⏳ 正在运行快照更新。。。 CI: Open |
|
测试案例没过需要处理下 �[7m FAIL �[27m src/action-sheet/__test__/index.test.jsx�[2m > ActionSheet�[2m > props�[2m > visible
AssertionError: expected true to be falsy
- Expected
+ Received
- false
+ true
�[2m❯ src/action-sheet/__test__/index.test.jsx:�[2m116:57
114| },
115| });
116| expect(wrapper.find(`.${prefix}-popup`).exists()).toBeFalsy();
| ^
117| await wrapper.setProps({
118| visible: true,
�[2m⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯ |
betavs
force-pushed
the
feature/popup-to-tsx
branch
from
f3517b4
to
266b693
Compare
anlyyao
reviewed
Oct 30, 2024
src/popup/popup.tsx
Outdated
| @@ -133,7 +112,7 @@ export default defineComponent({ | |||
|
|
|||
| useLockScroll(popupRef, () => wrapperVisible.value && props.preventScrollThrough, popupClass.value); | |||
|
|
|||
| return { | |||
| context.expose({ | |||
src/popup/popup.tsx
Outdated
|
|
||
| const renderPopupContent = | ||
| process.env.NODE_ENV === 'production' ? ( | ||
| <Teleport to={to.value} disabled={!to.value}> |
anlyyao
reviewed
Oct 30, 2024
src/popup/popup.tsx
Outdated
| import { getAttach } from '../shared/dom'; | ||
| import { usePrefixClass } from '../hooks/useClass'; | ||
| import { useLockScroll } from '../hooks/useLockScroll'; | ||
| import { useContent, useTNodeJSX } from '@/hooks/tnode'; |
betavs
force-pushed
the
feature/popup-to-tsx
branch
from
266b693
to
158030f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
refactor(Popup):
sfctotsx本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单