Fix image decoding color space issue on Android #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith2018
requested review from
domchen,
Hparty,
lvpengwei and
shlzxjp
as code owners
keith2018
force-pushed
the
keith2018-patch-colorspace-fix
branch
2 times, most recently
from
2d0a4ea
to
92647ac
Compare
domchen
reviewed
Nov 7, 2024
keith2018
force-pushed
the
keith2018-patch-colorspace-fix
branch
from
92647ac
to
83a2ef9
Compare
domchen
reviewed
Nov 7, 2024
keith2018
force-pushed
the
keith2018-patch-colorspace-fix
branch
from
83a2ef9
to
06c6e8d
Compare
domchen
approved these changes
Nov 7, 2024
domchen
pushed a commit
that referenced
this pull request
Nov 11, 2024
kevingpqi123
pushed a commit
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 936d8fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use
BitmapFactoryfor image decoding on the Android platform and do not setinPreferredColorSpace, the decoded color space will remain unchanged. If the original image is in the Display P3 color space and is used directly as a texture, it may result in color deviation. so it is necessary to setinPreferredColorSpaceto perform color space conversion (to sRGB).Ref: https://developer.android.com/reference/kotlin/android/graphics/BitmapFactory.Options#inpreferredcolorspace