Fix In some cases, pkt_num_offset greater than left can cause a panic #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #426 +/- ##
===========================================
+ Coverage 94.78% 95.19% +0.41%
===========================================
Files 50 50
Lines 34297 34301 +4
===========================================
+ Hits 32507 32653 +146
+ Misses 1790 1648 -142 ☔ View full report in Codecov by Sentry. |
iyangsj
reviewed
Nov 15, 2024
src/connection/connection.rs
Outdated
| @@ -1708,7 +1708,7 @@ impl Connection { | |||
| } | |||
|
|
|||
| // Encode packet number | |||
| let len = packet::encode_packet_num(pkt_num, pkt_num_len, &mut out[pkt_num_offset..left])?; | |||
| let len = packet::encode_packet_num(pkt_num, pkt_num_len, &mut out[pkt_num_offset..])?; | |||
There was a problem hiding this comment.
此处改为如下更好（可限制encode_packet_num()操作的缓冲区范围并拦截可能意外引入的错误）
&mut out[pkt_num_offset..pkt_num_offset+ pkt_num_len]
注：line 1700～line 1706的检查，可以保证 out的长度大于 pkt_num_offset+pkt_num_len
There was a problem hiding this comment.
我重新建了一个分支，修改后又提了一个pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #Issue 425