Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(minimap): reduce log noise from CharacterOverlay #133

Merged
merged 1 commit into from
Jan 29, 2021
Merged

chore(minimap): reduce log noise from CharacterOverlay #133

merged 1 commit into from
Jan 29, 2021

Conversation

skaldarnar
Copy link
Contributor

@skaldarnar skaldarnar commented Jan 29, 2021 •
edited
Loading

  • chore: register and evaluate the overlay texture once during setup
  • fix: only skip entities without location (don't abort rendering)
  • perf?: check if icon is present first (no need to do math for those)
  • chore: slightly improve logging messages

The following is only logged once when initializing the CharacterOverly now:

12:49:45.202 [main] WARN  o.t.m.minimap.CharacterOverlay - No icon found for citizen 'MetalRenegades:marketCitizen'
12:49:45.203 [main] WARN  o.t.m.minimap.CharacterOverlay - No icon found for citizen 'MetalRenegades:gooeyCitizen'
12:49:45.203 [main] WARN  o.t.m.minimap.CharacterOverlay - No icon found for citizen 'MetalRenegades:neutralGooey'
12:49:45.203 [main] WARN  o.t.m.minimap.CharacterOverlay - No icon found for citizen 'MetalRenegades:nocturnalGooey'
12:49:45.203 [main] WARN  o.t.m.minimap.CharacterOverlay - No icon found for citizen 'MetalRenegades:scaredGooey'
12:49:45.203 [main] WARN  o.t.m.minimap.CharacterOverlay - No icon found for citizen 'MetalRenegades:angryGooey'
12:49:45.203 [main] WARN  o.t.m.minimap.CharacterOverlay - No icon found for citizen 'MetalRenegades:friendlyGooey'

Related to #126 (reduces log spam, does not fix missing icons).
Related to #111 (hard-coded asset references).

@skaldarnar
chore(minimap): reduce log noise from CharacterOverlay
4fb9a73 
- chore: register and evaluate the overlay texture once during setup
- fix: only skip entities without location (don't abort rendering)
- perf?: check if icon is present first (no need to do math for those)
- chore: slightly improve logging messages
DarkWeird
DarkWeird approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@DarkWeird DarkWeird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

@DarkWeird DarkWeird merged commit cc06b5d into develop Jan 29, 2021
@DarkWeird DarkWeird deleted the chore/reduce-log-spam branch January 29, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkWeird DarkWeird DarkWeird approved these changes

@jdrueckert jdrueckert Awaiting requested review from jdrueckert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skaldarnar @DarkWeird