This repository has been archived by the owner on Aug 4, 2024. It is now read-only.
Some test portability fixes #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not portable and isn't needed here, where we only want to override a single element.
Could you provide instances of those failing tests in core? (I ask because we have no smoke-test reporting on VMS for core, for this distribution or for probably anything else.) thanks. |
|
On Aug 4, 2024, at 9:54 AM, James E Keenan ***@***.***> wrote:
Several Test2 tests are failing in Perl core on VMS. This gets them passing.
Could you provide instances of those failing tests in core? (I ask because we have no smoke-test reporting on VMS for core, for this distribution or for probably anything else.) thanks.
These are the ones that are currently failing:
cpan/Test2-Suite/t/modules/Require/AutomatedTesting .............. FAILED--no leader found
cpan/Test2-Suite/t/modules/Require/ExtendedTesting ............... FAILED--no leader found
cpan/Test2-Suite/t/modules/Require/NonInteractiveTesting ......... FAILED--no leader found
cpan/Test2-Suite/t/modules/Require/ReleaseTesting ................ FAILED--no leader found
cpan/Test2-Suite/t/regression/291-async-subtest-done-testing ..... FAILED--no leader found
The first 4 fail because they are trying to do a list assignment to %ENV, which is not possible on VMS. The last one fails because it is trying to do a fork(), which is also not available on VMS.
…________________________________________
Craig A. Berry
"... getting out of a sonnet is much more
difficult than getting in."
Brad Leithauser
|
craigberry
added a commit
to Perl/perl5
that referenced
this pull request
Aug 4, 2024
Also sent upstream: Test-More/Test2-Suite#296
exodist
reviewed
Aug 4, 2024
| @@ -1,4 +1,11 @@ | |||
| use Test2::V0; | |||
|
|
|||
| BEGIN { | |||
There was a problem hiding this comment.
This should be:
use Test2::Require::RealFork
https://metacpan.org/pod/Test2::Require::RealFork
I will merge the PR, and then change this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several Test2 tests are failing in Perl core on VMS. This gets them passing.