-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple reports with different granularity (file, class, method) #9
base: master
Are you sure you want to change the base?
Commits on Aug 26, 2020
-
AbstractSmell became interface, getHasSmell and getHasProductionFile …
…renamed to hasSmell and hasProductionFile, reformatted code, pulled up similar members between TestClass and TestMethod, removed commented code, redundant comments and unused methods and variables, moved member initializeSmells to Main, extracted parseIntoCompilationUnit from duplication on detectSmells and reorganized for-loop on detectSmells
Configuration menu - View commit details
-
Copy full SHA for 29d6a9b - Browse repository at this point
Copy the full SHA 29d6a9bView commit details -
Moved Util members to AbstractSmell (making it abstract class again),…
… fixed some warnings from GeneralFixture.java
Configuration menu - View commit details
-
Copy full SHA for b33956d - Browse repository at this point
Copy the full SHA b33956dView commit details -
Pulled smellyElement member up to AbstractSmell, Moved with delegatio…
…n the validation methods from AbstractSmell to MethodValidator
Configuration menu - View commit details
-
Copy full SHA for 287a2fb - Browse repository at this point
Copy the full SHA 287a2fbView commit details -
Refactored Main.java, renamed some methods (TestSmellDetector.addSmel…
…l -> addDetectableSmell, TestFile.addSmell -> addDetectedSmell, ResultsWriter.writeColumnName -> writeColumnNames)
Configuration menu - View commit details
-
Copy full SHA for 9ba345a - Browse repository at this point
Copy the full SHA 9ba345aView commit details -
Implemented MethodValidator and TestSmellDetector unit tests, added '…
…BeforeEach' as setUp annotation and empty catch block on detectSmells (preventing FileNotFoundException propagation)
Configuration menu - View commit details
-
Copy full SHA for 3497f82 - Browse repository at this point
Copy the full SHA 3497f82View commit details
Commits on Aug 27, 2020
-
Removed writeOutput aliases on ResultsWriter, renamed writeOutput to …
…writeCSV, moved output file handling methods from Main to ResultsWriter, related CSV header definition with properties through HashMap on TestFile.getTestDescriptionEntries method
Configuration menu - View commit details
-
Copy full SHA for b67eed0 - Browse repository at this point
Copy the full SHA b67eed0View commit details -
Extracted super class SmellsContainer from TestFile (use it on Result…
…sWriter), removed code duplication by extracting methods (TestFile.removeExtension and TestFile.extractFileFromPath), removed TestSmellDetector.detectSmells return confusion (it was returning the param it received)
Configuration menu - View commit details
-
Copy full SHA for 0a8a036 - Browse repository at this point
Copy the full SHA 0a8a036View commit details -
A relative file path without separator is equal to the filename, a fi…
…lename without "." (dot) remain the same when its extension is removed
Configuration menu - View commit details
-
Copy full SHA for 3e7eb48 - Browse repository at this point
Copy the full SHA 3e7eb48View commit details -
On TestFile constructor, file without extension and path without sepa…
…rator aren't treated as special cases, they throw an IllegalArgumentException instead
Configuration menu - View commit details
-
Copy full SHA for 4821c62 - Browse repository at this point
Copy the full SHA 4821c62View commit details
Commits on Aug 28, 2020
-
SmellsContainer became an interface with default methods and it's sup…
…erclass of SmellyElement, TestClass and TestMethod TestSmellDetector add Smells on them (they now are compatible to ResultsWriter operations).
Configuration menu - View commit details
-
Copy full SHA for aa1fe2d - Browse repository at this point
Copy the full SHA aa1fe2dView commit details -
New class extracted from Main. It will handle report granularity-leve…
…l configuration.
Configuration menu - View commit details
-
Copy full SHA for e2e6bd3 - Browse repository at this point
Copy the full SHA e2e6bd3View commit details -
ExportingGranularityController renamed to ReportController, report gr…
…anularity cfg by properties and handled by ReportController. Supported granularities: CLASS, METHOD and FILE.
Configuration menu - View commit details
-
Copy full SHA for 1825641 - Browse repository at this point
Copy the full SHA 1825641View commit details -
IntegrationTest implemented for TestSmellDetector.detectSmells (tagge…
…d with custom annotation and configured properly on maven). Necessary changes to TestSmellDetector to handle tested code on resources (also included on commit).
Configuration menu - View commit details
-
Copy full SHA for c750a85 - Browse repository at this point
Copy the full SHA c750a85View commit details
Commits on Aug 30, 2020
-
Renamed TestSmellDetectorIT.testSmellDetector to 'testSmellsFreeProje…
…ct' and improved assertions (validates no smells is detected); Dropped lambda usage on MethodValidatorTest (using Command pattern instead)
Configuration menu - View commit details
-
Copy full SHA for 1ee8b41 - Browse repository at this point
Copy the full SHA 1ee8b41View commit details
Commits on Sep 18, 2020
-
Optimized AbstractSmell.hasSmell, made prodFile optional, merging sam…
…e type smells on SmellsContainer.addDetectedSmell
Configuration menu - View commit details
-
Copy full SHA for 871a284 - Browse repository at this point
Copy the full SHA 871a284View commit details -
Breaking change: no null should be added as testFile's smells on Test…
…SmellDetector.detectSmells (it prevents duplicate smells removal on smells merging)
Configuration menu - View commit details
-
Copy full SHA for 81b1eaa - Browse repository at this point
Copy the full SHA 81b1eaaView commit details -
Tests implemented for each TestSmell (production file specified only …
…when required). IgnoredTest results in false positive; ConstructorInitialization and GeneralFixture are not detected.
Configuration menu - View commit details
-
Copy full SHA for ff64c7d - Browse repository at this point
Copy the full SHA ff64c7dView commit details
Commits on Sep 25, 2020
-
ReportController new constructor receive granularities list, relative…
… path extraction based on first occurrence instead of last (fixing Queue test-case), ReportController tests partially implemented (FILE granularity is working)
Configuration menu - View commit details
-
Copy full SHA for d24a6eb - Browse repository at this point
Copy the full SHA d24a6ebView commit details
Commits on Sep 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4f1e412 - Browse repository at this point
Copy the full SHA 4f1e412View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8df9dc7 - Browse repository at this point
Copy the full SHA 8df9dc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0d1c34 - Browse repository at this point
Copy the full SHA f0d1c34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 833911e - Browse repository at this point
Copy the full SHA 833911eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5b3178 - Browse repository at this point
Copy the full SHA f5b3178View commit details
Commits on Sep 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d36797b - Browse repository at this point
Copy the full SHA d36797bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea58040 - Browse repository at this point
Copy the full SHA ea58040View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a357fd - Browse repository at this point
Copy the full SHA 2a357fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e8e887 - Browse repository at this point
Copy the full SHA 7e8e887View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57c0335 - Browse repository at this point
Copy the full SHA 57c0335View commit details
Commits on Sep 28, 2020
-
fixed ConstructorInitializationIntegrationTest, added class granulari…
…ty tests and missing Queue (smells-free) project resource
Configuration menu - View commit details
-
Copy full SHA for 3723487 - Browse repository at this point
Copy the full SHA 3723487View commit details -
ReportControllerIntegrationTests better organized (split in 3 classes…
…) and removed outdated comment
Configuration menu - View commit details
-
Copy full SHA for f17e982 - Browse repository at this point
Copy the full SHA f17e982View commit details -
Configuration menu - View commit details
-
Copy full SHA for daecf80 - Browse repository at this point
Copy the full SHA daecf80View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2a994c - Browse repository at this point
Copy the full SHA c2a994cView commit details
Commits on Oct 25, 2020
-
Fixed outputting header repeatedly for each inputted TestFile; Optimi…
…zed code (Smells and SmellyElements collections are internally treated as Set, but returned as list): simplified "contains" method and "upsert" operation.
Configuration menu - View commit details
-
Copy full SHA for d972bd3 - Browse repository at this point
Copy the full SHA d972bd3View commit details -
Fixed multi-file repeated report entries:
- Isolating AbstractSmell instances per TestFile - SmellsContainer turned into a class and testSmells list made non-static
Configuration menu - View commit details
-
Copy full SHA for 15d7a5d - Browse repository at this point
Copy the full SHA 15d7a5dView commit details
Commits on Oct 26, 2020
-
Implemented failing tests for class granularity report and fixed Depe…
…ndentTest omission on failure
Configuration menu - View commit details
-
Copy full SHA for 3073395 - Browse repository at this point
Copy the full SHA 3073395View commit details
Commits on Oct 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9d11c39 - Browse repository at this point
Copy the full SHA 9d11c39View commit details -
Fixed DefaultTest and IgnoredTest omission/null on failure; added sup…
…port for JUnit5 @disabled annotation; updated tests
Configuration menu - View commit details
-
Copy full SHA for d3d27a7 - Browse repository at this point
Copy the full SHA d3d27a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for beeae67 - Browse repository at this point
Copy the full SHA beeae67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 233f1c1 - Browse repository at this point
Copy the full SHA 233f1c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 397e840 - Browse repository at this point
Copy the full SHA 397e840View commit details
Commits on Jun 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 264f657 - Browse repository at this point
Copy the full SHA 264f657View commit details -
Added final modifier to TestSmellDetector class
- Addressing @ellieMayVelasquez comment on my PR; - Fixing getResource bad practice.
Configuration menu - View commit details
-
Copy full SHA for d30bc86 - Browse repository at this point
Copy the full SHA d30bc86View commit details