Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple reports with different granularity (file, class, method) #9

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Commits on Aug 26, 2020

  1. AbstractSmell became interface, getHasSmell and getHasProductionFile …

    …renamed to hasSmell and hasProductionFile, reformatted code, pulled up similar members between TestClass and TestMethod, removed commented code, redundant comments and unused methods and variables, moved member initializeSmells to Main, extracted parseIntoCompilationUnit from duplication on detectSmells and reorganized for-loop on detectSmells
    victorgveloso committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    29d6a9b View commit details
    Browse the repository at this point in the history
  2. Moved Util members to AbstractSmell (making it abstract class again),…

    … fixed some warnings from GeneralFixture.java
    victorgveloso authored and BuildTools committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    b33956d View commit details
    Browse the repository at this point in the history
  3. Pulled smellyElement member up to AbstractSmell, Moved with delegatio…

    …n the validation methods from AbstractSmell to MethodValidator
    victorgveloso authored and BuildTools committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    287a2fb View commit details
    Browse the repository at this point in the history
  4. Refactored Main.java, renamed some methods (TestSmellDetector.addSmel…

    …l -> addDetectableSmell, TestFile.addSmell -> addDetectedSmell, ResultsWriter.writeColumnName -> writeColumnNames)
    victorgveloso authored and BuildTools committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    9ba345a View commit details
    Browse the repository at this point in the history
  5. Implemented MethodValidator and TestSmellDetector unit tests, added '…

    …BeforeEach' as setUp annotation and empty catch block on detectSmells (preventing FileNotFoundException propagation)
    victorgveloso authored and BuildTools committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    3497f82 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Removed writeOutput aliases on ResultsWriter, renamed writeOutput to …

    …writeCSV, moved output file handling methods from Main to ResultsWriter, related CSV header definition with properties through HashMap on TestFile.getTestDescriptionEntries method
    victorgveloso authored and BuildTools committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    b67eed0 View commit details
    Browse the repository at this point in the history
  2. Extracted super class SmellsContainer from TestFile (use it on Result…

    …sWriter), removed code duplication by extracting methods (TestFile.removeExtension and TestFile.extractFileFromPath), removed TestSmellDetector.detectSmells return confusion (it was returning the param it received)
    victorgveloso authored and BuildTools committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    0a8a036 View commit details
    Browse the repository at this point in the history
  3. A relative file path without separator is equal to the filename, a fi…

    …lename without "." (dot) remain the same when its extension is removed
    victorgveloso authored and BuildTools committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    3e7eb48 View commit details
    Browse the repository at this point in the history
  4. On TestFile constructor, file without extension and path without sepa…

    …rator aren't treated as special cases, they throw an IllegalArgumentException instead
    victorgveloso authored and BuildTools committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    4821c62 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. SmellsContainer became an interface with default methods and it's sup…

    …erclass of SmellyElement, TestClass and TestMethod TestSmellDetector add Smells on them (they now are compatible to ResultsWriter operations).
    victorgveloso authored and BuildTools committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    aa1fe2d View commit details
    Browse the repository at this point in the history
  2. New class extracted from Main. It will handle report granularity-leve…

    …l configuration.
    victorgveloso authored and BuildTools committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    e2e6bd3 View commit details
    Browse the repository at this point in the history
  3. ExportingGranularityController renamed to ReportController, report gr…

    …anularity cfg by properties and handled by ReportController. Supported granularities: CLASS, METHOD and FILE.
    victorgveloso authored and BuildTools committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    1825641 View commit details
    Browse the repository at this point in the history
  4. IntegrationTest implemented for TestSmellDetector.detectSmells (tagge…

    …d with custom annotation and configured properly on maven). Necessary changes to TestSmellDetector to handle tested code on resources (also included on commit).
    victorgveloso authored and BuildTools committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    c750a85 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. Renamed TestSmellDetectorIT.testSmellDetector to 'testSmellsFreeProje…

    …ct' and improved assertions (validates no smells is detected); Dropped lambda usage on MethodValidatorTest (using Command pattern instead)
    victorgveloso committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    1ee8b41 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Optimized AbstractSmell.hasSmell, made prodFile optional, merging sam…

    …e type smells on SmellsContainer.addDetectedSmell
    victorgveloso committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    871a284 View commit details
    Browse the repository at this point in the history
  2. Breaking change: no null should be added as testFile's smells on Test…

    …SmellDetector.detectSmells (it prevents duplicate smells removal on smells merging)
    victorgveloso committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    81b1eaa View commit details
    Browse the repository at this point in the history
  3. Tests implemented for each TestSmell (production file specified only …

    …when required). IgnoredTest results in false positive; ConstructorInitialization and GeneralFixture are not detected.
    victorgveloso committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    ff64c7d View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. ReportController new constructor receive granularities list, relative…

    … path extraction based on first occurrence instead of last (fixing Queue test-case), ReportController tests partially implemented (FILE granularity is working)
    victorgveloso committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    d24a6eb View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Configuration menu
    Copy the full SHA
    4f1e412 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8df9dc7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f0d1c34 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    833911e View commit details
    Browse the repository at this point in the history
  5. Fixed some warnings

    victorgveloso committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    f5b3178 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Configuration menu
    Copy the full SHA
    d36797b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea58040 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a357fd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7e8e887 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    57c0335 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. fixed ConstructorInitializationIntegrationTest, added class granulari…

    …ty tests and missing Queue (smells-free) project resource
    victorgveloso committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    3723487 View commit details
    Browse the repository at this point in the history
  2. ReportControllerIntegrationTests better organized (split in 3 classes…

    …) and removed outdated comment
    victorgveloso committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    f17e982 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    daecf80 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c2a994c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. Fixed outputting header repeatedly for each inputted TestFile; Optimi…

    …zed code (Smells and SmellyElements collections are internally treated as Set, but returned as list): simplified "contains" method and "upsert" operation.
    victorgveloso committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    d972bd3 View commit details
    Browse the repository at this point in the history
  2. Fixed multi-file repeated report entries:

     - Isolating AbstractSmell instances per TestFile
     - SmellsContainer turned into a class and testSmells list made non-static
    victorgveloso committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    15d7a5d View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Implemented failing tests for class granularity report and fixed Depe…

    …ndentTest omission on failure
    victorgveloso committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    3073395 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Configuration menu
    Copy the full SHA
    9d11c39 View commit details
    Browse the repository at this point in the history
  2. Fixed DefaultTest and IgnoredTest omission/null on failure; added sup…

    …port for JUnit5 @disabled annotation; updated tests
    victorgveloso committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    d3d27a7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    beeae67 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    233f1c1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    397e840 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Configuration menu
    Copy the full SHA
    264f657 View commit details
    Browse the repository at this point in the history
  2. Added final modifier to TestSmellDetector class

    - Addressing @ellieMayVelasquez comment on my PR;
    - Fixing getResource bad practice.
    victorgveloso committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    d30bc86 View commit details
    Browse the repository at this point in the history