bugfix: Replaced inappropriate is
comparison with ==
#2157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR fixes a logical bug in your codebase
Description
In file gui.py, there's a comparison that compares an empty list to an object using
is
operator. This is not the correct way to compare objects with empty list or dict.For example, running the code below will give the output:
As a result, it's better to perform comparison using
==
operator thanis
.Contribution
All contributions made in this PR follows Developer Certificate of Origin
Comments
If you think such fixes aren't necessary for your project, and you'd like me to find some better bugs / code-to-fix, then please let me know. I'll be happy to contribute.