Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Replaced inappropriate is comparison with == #2157

Merged

Conversation

fazledyn
Copy link
Contributor

@fazledyn fazledyn commented Oct 1, 2024

Introduction

This PR fixes a logical bug in your codebase

Description

In file gui.py, there's a comparison that compares an empty list to an object using is operator. This is not the correct way to compare objects with empty list or dict.

For example, running the code below will give the output:

x = []
print(x is [])
False

As a result, it's better to perform comparison using == operator than is.

Contribution

All contributions made in this PR follows Developer Certificate of Origin

Comments

If you think such fixes aren't necessary for your project, and you'd like me to find some better bugs / code-to-fix, then please let me know. I'll be happy to contribute.

@donn
Copy link
Collaborator

donn commented Oct 2, 2024

No, this is super helpful. I'm left wondering why the linter didn't catch that.

Thank you.

@donn donn merged commit 1b3cf10 into The-OpenROAD-Project:master Oct 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants