Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Fit perimeter.cpp to guidelines #2911

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
236 changes: 39 additions & 197 deletions math/perimeter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
* @file
* @brief Implementations for the
* [perimeter](https://en.wikipedia.org/wiki/Perimeter) of various shapes
* @details The of a shape is the amount of 2D space it takes up.
* All shapes have a formula for their perimeter.
* @details The perimeter of a shape is the sum of the lengths of its sides
* or edges. All shapes have a formula for their perimeter.
* These implementations support multiple return types.
*
* @author [OGscorpion](https://github.com/OGscorpion)
Expand All @@ -30,8 +30,7 @@ T square_perimeter(T length) {
}

/**
* @brief perimeter of a [rectangle](https://en.wikipedia.org/wiki/Rectangle) (
* 2(l + w) )
* @brief perimeter of a [rectangle](https://en.wikipedia.org/wiki/Rectangle) ( 2*(l + w) )
* @param length is the length of the rectangle
* @param width is the width of the rectangle
* @returns perimeter of the rectangle
Expand All @@ -42,15 +41,15 @@ T rect_perimeter(T length, T width) {
}

/**
* @brief perimeter of a [triangle](https://en.wikipedia.org/wiki/Triangle) (a +
* b + c)
* @param base is the length of the bottom side of the triangle
* @param height is the length of the tallest point in the triangle
* @brief perimeter of a [triangle](https://en.wikipedia.org/wiki/Triangle) (a + b + c)
* @param side1 is one side of the triangle
* @param side2 is the second side of the triangle
* @param side3 is the third side of the triangle
* @returns perimeter of the triangle
*/
template <typename T>
T triangle_perimeter(T base, T height, T hypotenuse) {
return base + height + hypotenuse;
T triangle_perimeter(T side1, T side2, T side3) {
return side1 + side2 + side3;
}

/**
Expand All @@ -66,222 +65,65 @@ T circle_perimeter(T radius) {

/**
* @brief perimeter of a
* [parallelogram](https://en.wikipedia.org/wiki/Parallelogram) 2(b + h)
* @param base is the length of the bottom side of the parallelogram
* @param height is the length of the tallest point in the parallelogram
* [parallelogram](https://en.wikipedia.org/wiki/Parallelogram) 2(s1 + s2)
* @param side1 is the base side of the parallelogram
* @param side2 is the other side of the parallelogram
* @returns perimeter of the parallelogram
*/
template <typename T>
T parallelogram_perimeter(T base, T height) {
return 2 * (base + height);
T parallelogram_perimeter(T side1, T side2) {
return 2 * (side1 + side2);
}

/**
* @brief surface perimeter of a [cube](https://en.wikipedia.org/wiki/Cube) ( 12
* * l)
* @param length is the length of the cube
* @returns surface perimeter of the cube
*/
template <typename T>
T cube_surface_perimeter(T length) {
return 12 * length;
}

/**
* @brief surface perimeter of a
* [n-polygon](https://www.cuemath.com/measurement/perimeter-of-polygon/) ( n *
* l)
* @param length is the length of the polygon
* @brief perimeter of an
* [n-sided_regular_polygon](https://www.cuemath.com/measurement/perimeter-of-polygon/) (n * l)
* @param sides is the number of sides of the polygon
* @returns surface perimeter of the polygon
* @param length is the length of each side
* @returns perimeter of the regular polygon
*/
template <typename T>
T n_polygon_surface_perimeter(T sides, T length) {
T n_sides_regular_polygon_perimeter(T sides, T length) {
return sides * length;
}

/**
* @brief surface perimeter of a
* [cylinder](https://en.wikipedia.org/wiki/Cylinder) (2 * radius + 2 * height)
* @param radius is the radius of the cylinder
* @param height is the height of the cylinder
* @returns surface perimeter of the cylinder
*/
template <typename T>
T cylinder_surface_perimeter(T radius, T height) {
return (2 * radius) + (2 * height);
}
} // namespace math

/**
* @brief Self-test implementations
* @returns void
*/
static void test() {
// I/O variables for testing
uint16_t int_length = 0; // 16 bit integer length input
uint16_t int_width = 0; // 16 bit integer width input
uint16_t int_base = 0; // 16 bit integer base input
uint16_t int_height = 0; // 16 bit integer height input
uint16_t int_hypotenuse = 0; // 16 bit integer hypotenuse input
uint16_t int_sides = 0; // 16 bit integer sides input
uint16_t int_expected = 0; // 16 bit integer expected output
uint16_t int_perimeter = 0; // 16 bit integer output

float float_length = NAN; // float length input
float float_expected = NAN; // float expected output
float float_perimeter = NAN; // float output

double double_length = NAN; // double length input
double double_width = NAN; // double width input
double double_radius = NAN; // double radius input
double double_height = NAN; // double height input
double double_expected = NAN; // double expected output
double double_perimeter = NAN; // double output

// 1st test
int_length = 5;
int_expected = 20;
int_perimeter = math::square_perimeter(int_length);

std::cout << "perimeter OF A SQUARE (int)" << std::endl;
std::cout << "Input Length: " << int_length << std::endl;
std::cout << "Expected Output: " << int_expected << std::endl;
std::cout << "Output: " << int_perimeter << std::endl;
assert(int_perimeter == int_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;

// 2nd test
float_length = 2.5;
float_expected = 10;
float_perimeter = math::square_perimeter(float_length);

std::cout << "perimeter OF A SQUARE (float)" << std::endl;
std::cout << "Input Length: " << float_length << std::endl;
std::cout << "Expected Output: " << float_expected << std::endl;
std::cout << "Output: " << float_perimeter << std::endl;
assert(float_perimeter == float_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;

// 3rd test
int_length = 4;
int_width = 7;
int_expected = 22;
int_perimeter = math::rect_perimeter(int_length, int_width);

std::cout << "perimeter OF A RECTANGLE (int)" << std::endl;
std::cout << "Input Length: " << int_length << std::endl;
std::cout << "Input Width: " << int_width << std::endl;
std::cout << "Expected Output: " << int_expected << std::endl;
std::cout << "Output: " << int_perimeter << std::endl;
assert(int_perimeter == int_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;

// 4th test
double_length = 2.5;
double_width = 5.7;
double_expected = 16.4;
double_perimeter = math::rect_perimeter(double_length, double_width);

std::cout << "perimeter OF A RECTANGLE (double)" << std::endl;
std::cout << "Input Length: " << double_length << std::endl;
std::cout << "Input Width: " << double_width << std::endl;
std::cout << "Expected Output: " << double_expected << std::endl;
std::cout << "Output: " << double_perimeter << std::endl;
assert(double_perimeter == double_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;

// 5th test
int_base = 10;
int_height = 3;
int_hypotenuse = 5;
int_expected = 18;
int_perimeter =
math::triangle_perimeter(int_base, int_height, int_hypotenuse);

std::cout << "perimeter OF A TRIANGLE" << std::endl;
std::cout << "Input Base: " << int_base << std::endl;
std::cout << "Input Height: " << int_height << std::endl;
std::cout << "Expected Output: " << int_expected << std::endl;
std::cout << "Output: " << int_perimeter << std::endl;
assert(int_perimeter == int_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;

// 6th test
double_radius = 6;
double_expected =
37.69911184307752; // rounded down because the double datatype
// truncates after 14 decimal places
double_perimeter = math::circle_perimeter(double_radius);

std::cout << "perimeter OF A CIRCLE" << std::endl;
std::cout << "Input Radius: " << double_radius << std::endl;
std::cout << "Expected Output: " << double_expected << std::endl;
std::cout << "Output: " << double_perimeter << std::endl;
assert(double_perimeter == double_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;

// 7th test
int_base = 6;
int_height = 7;
int_expected = 26;
int_perimeter = math::parallelogram_perimeter(int_base, int_height);

std::cout << "perimeter OF A PARALLELOGRAM" << std::endl;
std::cout << "Input Base: " << int_base << std::endl;
std::cout << "Input Height: " << int_height << std::endl;
std::cout << "Expected Output: " << int_expected << std::endl;
std::cout << "Output: " << int_perimeter << std::endl;
assert(int_perimeter == int_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;
std::cout << "Running Tests..." << std::endl;

// Test square perimeter
assert(math::square_perimeter(5) == 20);
assert(math::square_perimeter(2.5f) == 10.0f);

// 8th test
double_length = 5.5;
double_expected = 66.0;
double_perimeter = math::cube_surface_perimeter(double_length);
// Test rectangle perimeter
assert(math::rect_perimeter(4, 7) == 22);
assert(std::abs(math::rect_perimeter(2.5, 5.7) - 16.4) < 1e-4);

std::cout << "SURFACE perimeter OF A CUBE" << std::endl;
std::cout << "Input Length: " << double_length << std::endl;
std::cout << "Expected Output: " << double_expected << std::endl;
std::cout << "Output: " << double_perimeter << std::endl;
assert(double_perimeter == double_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;
// Test triangle perimeter
assert(math::triangle_perimeter(10, 3, 5) == 18);

// 9th test
int_sides = 7;
int_length = 10;
int_expected = 70;
int_perimeter = math::n_polygon_surface_perimeter(int_sides, int_length);
// Test circle perimeter
assert(std::abs(math::circle_perimeter(6.0) - 37.6991) < 1e-4);

std::cout << "SURFACE perimeter OF A N-POLYGON" << std::endl;
std::cout << "Input Sides: " << int_sides << std::endl;
std::cout << "Input Length: " << int_length << std::endl;
std::cout << "Expected Output: " << int_expected << std::endl;
std::cout << "Output: " << int_perimeter << std::endl;
assert(int_perimeter == int_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;
// Test parallelogram perimeter
assert(math::parallelogram_perimeter(6, 7) == 26);

// 10th test
double_radius = 4.0;
double_height = 7.0;
double_expected = 22.0;
double_perimeter =
math::cylinder_surface_perimeter(double_radius, double_height);
// Test N-sides regular polygon perimeter
assert(math::n_sides_regular_polygon_perimeter(7, 10) == 70);

std::cout << "SURFACE perimeter OF A CYLINDER" << std::endl;
std::cout << "Input Radius: " << double_radius << std::endl;
std::cout << "Input Height: " << double_height << std::endl;
std::cout << "Expected Output: " << double_expected << std::endl;
std::cout << "Output: " << double_perimeter << std::endl;
assert(double_perimeter == double_expected);
std::cout << "TEST PASSED" << std::endl << std::endl;
std::cout << "All Tests Passed!" << std::endl;
}

/**
* @brief Main function
* @returns 0 on exit
* @brief Main function to run the test cases
* @returns 0 on successful execution
*/
int main() {
test(); // run self-test implementations
test(); // Run the test cases
return 0;
}