[OTHER] Cleanup classes with very strange design #5164

vil02 · 2024-05-18T10:36:25Z

What would you like to share?

There are probably many classes in this repository, which have some strange design - we should update all of them. I think we can start with cleaning up these:

List of the classes needing redesign:

AllPathsFromSourceToTarget
ArrayCombination (refactor: redesign ArrayCombination #5181 by @yuvashreenarayanan3)
Combination
ColumnarTranspositionCipher
StringMatchFiniteAutomata (refactor: redesign StringMatchFiniteAutomata #5222 by @samuelfac)
LetterCombinationsOfPhoneNumber (refactor: redesign LetterCombinationsOfPhoneNumber #5221 by @samuelfac)

(@siriak, @BamaCharanChhandogi feel free to edit the list above)

Additional information

How to contribute

select one class form the list above such that no one else is working on (and is not done yet),
write a comment "Hey, I am working on XYZ", where XYZ is your selected class,
in your fork, please create a branch like cleanup_XYZ,
make your changes and create a pull-request, in which you mention this issue by writing something like "Related to #(this issue number)". Please make sure that you add all necessary tests. If possible, prefer parametrized tests.

Also feel free to suggest a class, which should be added to the list above.

The text was updated successfully, but these errors were encountered:

yuvashreenarayanan3 · 2024-05-26T16:24:05Z

Hey, I am working on "ArrayCombination"

JeysiStrokk · 2024-06-04T10:45:48Z

Hello I´m new here and I would like to help !!!

vil02 · 2024-06-04T20:44:07Z

Hello I´m new here and I would like to help !!!

@JeysiStrokk would you like to work on AllPathsFromSourceToTarget?

JeysiStrokk · 2024-06-05T09:05:35Z

@vil02 I´ll gladly do it. I´ll try my best !! Thanks a lot !!
I´m working on "AllPathsFromSourceToTarget"

samuelfac · 2024-06-12T10:11:22Z

I´m working on "LetterCombinationsOfPhoneNumber"

samuelfac · 2024-06-12T13:13:26Z

I´m working on "StringMatchFiniteAutomata"

samuelfac · 2024-06-12T15:06:33Z

I´m working on "ColumnarTranspositionCipher"

samuelfac · 2024-06-12T16:44:11Z

@vil02 I´ll gladly do it. I´ll try my best !! Thanks a lot !! I´m working on "AllPathsFromSourceToTarget"

Sorry, I refactored this class without seeing that you had already started. Now I saw in your repository that you only added the comments in the class. That's why I make the pull request.

samuelfac · 2024-06-12T17:34:43Z

I´m working on "Combination"

* Related to #5164 (Redesign of ArrayCombination) * Checkstyle fix * Clang_format * refactor: cleanup --------- Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com> Co-authored-by: vil02 <vil02@o2.pl>

AbeTheAmatuer · 2024-07-25T17:27:02Z

Can I work on "Combination", or "AllPathsFromSourceToTarget"? I know in the comments people were supposed to have worked on this, but they aren't marked as complete, so if they still need work I'd be happy to work on one of them.

siriak · 2024-07-25T20:21:12Z

@AbeTheAmatuer Sure, feel free to work on them!

AbeTheAmatuer · 2024-07-25T20:35:40Z

Thanks, I'll work on Combination.

AbeTheAmatuer · 2024-07-25T22:46:13Z

@siriak I did some cleanup for Combination. It was mostly fine, so I just changed the class name to, "CombinationGenerator", added some comments and changed a variable name for accuracy. I made a PR.

Edit: Ok so changing the class name impacted a bunch of other files so I changed it back and closed my pull request but I fixed the problem and am not sure how to make another one.

vil02 · 2024-07-26T07:14:46Z

@AbeTheAmatuer please have a look at:

by @samuelfac - these PR are in the stage almost to be merged. I am not sure if @samuelfac is planning to continue to work on them - it would be a pity if not..

AbeTheAmatuer · 2024-07-26T17:26:24Z

@vil02 Ok, do you want me to just review his commits?

Dileepkumar18311 · 2024-07-31T14:45:25Z

Hey, I am working on Combination

adityasarfare · 2024-08-19T22:55:26Z

Hey, can I help and Contribute in something ?

adityasarfare · 2024-08-20T15:47:00Z

hey im working on AllPathsFromSourceToTarget

TarunVishwakarma1 · 2024-09-10T08:54:47Z

Hey! I'm working on ColumnarTranspositionCipher

can you please tell me if you have any specific requirement in mind.

vil02 · 2024-09-10T16:41:10Z

can you please tell me if you have any specific requirement in mind.

#5223 is a good place to look at. A straightforward implementation with reasonable tests, should be good enough.

TarunVishwakarma1 · 2024-09-13T17:20:33Z

Sure, I'll start working on this 😊😊

SAIVARDHAN15 · 2024-09-24T12:40:58Z

Hey @TarunVishwakarma1, if you are good I am happy to work on #5223

TarunVishwakarma1 · 2024-09-24T13:22:17Z

Yes, sure go ahead.

SAIVARDHAN15 · 2024-09-25T05:06:54Z

thanks mate!
I will be working on "ColumnarTranspositionCipher"

Anurag127001 · 2024-09-30T14:42:15Z

I will be working on "AllPathsFromSourceToTarget"

…d up

SAIVARDHAN15 · 2024-10-09T17:36:22Z

hey @Anurag127001!
are you working on "AllPathsFromSourceToTarget", if you need any help, I happy to do so.

lorduke22 · 2024-10-19T13:56:55Z

Hello, I am working on "Combination"

Soumayadip937 · 2024-10-19T21:32:10Z

@siriak & @SAIVARDHAN15 is ColumnarTranspositionCipher available? I am new to open source contribution can I start work with this?

SAIVARDHAN15 · 2024-10-27T10:34:42Z

hey there @Soumayadip937, ColumnarTranspositionCipher is alreday closed. You may checkout other open issues.

vil02 added the awaiting triage Awaiting triage from a maintainer label May 18, 2024

siriak added enhancement help wanted and removed awaiting triage Awaiting triage from a maintainer labels May 21, 2024

yuvashreenarayanan3 added a commit to yuvashreenarayanan3/Java that referenced this issue May 26, 2024

Related to TheAlgorithms#5164 (Redesign of ArrayCombination)

c848bab

vil02 mentioned this issue May 27, 2024

refactor: redesign ArrayCombination #5181

Merged

6 tasks

samuelfac mentioned this issue Jun 12, 2024

refactor: redesign LetterCombinationsOfPhoneNumber #5221

Merged

6 tasks

samuelfac mentioned this issue Jun 12, 2024

refactor: redesign StringMatchFiniteAutomata #5222

Merged

6 tasks

samuelfac mentioned this issue Jun 12, 2024

Refactor: redesign ColumnarTranspositionCipher #5223

Closed

6 tasks

samuelfac mentioned this issue Jun 12, 2024

Refactor: redesign AllPathsFromSourceToTarget #5224

Closed

6 tasks

samuelfac mentioned this issue Jun 12, 2024

Refactor: Combination #5225

Closed

6 tasks

Anurag127001 pushed a commit to Anurag127001/Java that referenced this issue Sep 30, 2024

Related to TheAlgorithms#5164 AllPathsFromSourceToTarget class cleane…

96403db

…d up

yaswanth263 mentioned this issue Oct 8, 2024

> @vil02 I´ll gladly do it. I´ll try my best !! Thanks a lot !! I´m working on "AllPathsFromSourceToTarget" #5647

Closed

This was referenced Oct 19, 2024

Cleanup combination #5901

Closed

cleanup combination and combination test #5902

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OTHER] Cleanup classes with very strange design #5164

[OTHER] Cleanup classes with very strange design #5164

vil02 commented May 18, 2024 •

edited by siriak

Loading

yuvashreenarayanan3 commented May 26, 2024

JeysiStrokk commented Jun 4, 2024

vil02 commented Jun 4, 2024

JeysiStrokk commented Jun 5, 2024 •

edited

Loading

samuelfac commented Jun 12, 2024

samuelfac commented Jun 12, 2024

samuelfac commented Jun 12, 2024

samuelfac commented Jun 12, 2024

samuelfac commented Jun 12, 2024

AbeTheAmatuer commented Jul 25, 2024

siriak commented Jul 25, 2024

AbeTheAmatuer commented Jul 25, 2024

AbeTheAmatuer commented Jul 25, 2024 •

edited

Loading

vil02 commented Jul 26, 2024

AbeTheAmatuer commented Jul 26, 2024 •

edited

Loading

Dileepkumar18311 commented Jul 31, 2024

adityasarfare commented Aug 19, 2024

adityasarfare commented Aug 20, 2024

TarunVishwakarma1 commented Sep 10, 2024 •

edited

Loading

vil02 commented Sep 10, 2024

TarunVishwakarma1 commented Sep 13, 2024

SAIVARDHAN15 commented Sep 24, 2024

TarunVishwakarma1 commented Sep 24, 2024

SAIVARDHAN15 commented Sep 25, 2024

Anurag127001 commented Sep 30, 2024

SAIVARDHAN15 commented Oct 9, 2024

lorduke22 commented Oct 19, 2024

Soumayadip937 commented Oct 19, 2024 •

edited

Loading

SAIVARDHAN15 commented Oct 27, 2024

[OTHER] Cleanup classes with very strange design #5164

[OTHER] Cleanup classes with very strange design #5164

Comments

vil02 commented May 18, 2024 • edited by siriak Loading

What would you like to share?

List of the classes needing redesign:

Additional information

How to contribute

yuvashreenarayanan3 commented May 26, 2024

JeysiStrokk commented Jun 4, 2024

vil02 commented Jun 4, 2024

JeysiStrokk commented Jun 5, 2024 • edited Loading

samuelfac commented Jun 12, 2024

samuelfac commented Jun 12, 2024

samuelfac commented Jun 12, 2024

samuelfac commented Jun 12, 2024

samuelfac commented Jun 12, 2024

AbeTheAmatuer commented Jul 25, 2024

siriak commented Jul 25, 2024

AbeTheAmatuer commented Jul 25, 2024

AbeTheAmatuer commented Jul 25, 2024 • edited Loading

vil02 commented Jul 26, 2024

AbeTheAmatuer commented Jul 26, 2024 • edited Loading

Dileepkumar18311 commented Jul 31, 2024

adityasarfare commented Aug 19, 2024

adityasarfare commented Aug 20, 2024

TarunVishwakarma1 commented Sep 10, 2024 • edited Loading

vil02 commented Sep 10, 2024

TarunVishwakarma1 commented Sep 13, 2024

SAIVARDHAN15 commented Sep 24, 2024

TarunVishwakarma1 commented Sep 24, 2024

SAIVARDHAN15 commented Sep 25, 2024

Anurag127001 commented Sep 30, 2024

SAIVARDHAN15 commented Oct 9, 2024

lorduke22 commented Oct 19, 2024

Soumayadip937 commented Oct 19, 2024 • edited Loading

SAIVARDHAN15 commented Oct 27, 2024

vil02 commented May 18, 2024 •

edited by siriak

Loading

JeysiStrokk commented Jun 5, 2024 •

edited

Loading

AbeTheAmatuer commented Jul 25, 2024 •

edited

Loading

AbeTheAmatuer commented Jul 26, 2024 •

edited

Loading

TarunVishwakarma1 commented Sep 10, 2024 •

edited

Loading

Soumayadip937 commented Oct 19, 2024 •

edited

Loading