Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redesign ArrayCombination #5181

Merged

Conversation

yuvashreenarayanan3
Copy link
Contributor

@yuvashreenarayanan3 yuvashreenarayanan3 commented May 26, 2024

Related to #5164.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.33%. Comparing base (06927d3) to head (82aab4e).
Report is 148 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5181      +/-   ##
============================================
+ Coverage     40.32%   40.33%   +0.01%     
- Complexity     2482     2485       +3     
============================================
  Files           519      519              
  Lines         15473    15479       +6     
  Branches       2950     2950              
============================================
+ Hits           6239     6244       +5     
  Misses         8944     8944              
- Partials        290      291       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look into this class.

@vil02 vil02 changed the title Related to #5164 (Redesign of ArrayCombination) refactor: redesign ArrayCombination May 27, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Jun 27, 2024
@vil02 vil02 merged commit f83bb65 into TheAlgorithms:master Jul 10, 2024
5 checks passed
@vil02 vil02 mentioned this pull request Jul 10, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants