-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding class for generating all subsequences from a given List #5194
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5194 +/- ##
============================================
+ Coverage 38.63% 38.69% +0.05%
- Complexity 2379 2383 +4
============================================
Files 516 517 +1
Lines 15388 15403 +15
Branches 2957 2958 +1
============================================
+ Hits 5945 5960 +15
Misses 9158 9158
Partials 285 285 ☔ View full report in Codecov by Sentry. |
I like the fact that your code is generic. |
src/test/java/com/thealgorithms/backtracking/SubsequenceTest.java
Outdated
Show resolved
Hide resolved
…arametrized test. Fixed input parameter as final.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I made few renaming suggestions.
src/test/java/com/thealgorithms/backtracking/SubsequenceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/backtracking/SubsequenceFinder.java
Outdated
Show resolved
Hide resolved
src/test/java/com/thealgorithms/backtracking/SubsequenceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/thealgorithms/backtracking/SubsequenceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/thealgorithms/backtracking/SubsequenceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/thealgorithms/backtracking/SubsequenceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/thealgorithms/backtracking/SubsequenceTest.java
Outdated
Show resolved
Hide resolved
Renaming test method. Adding duplication test. Renaming TestData to TestCase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Dzięki!
clang-format -i --style=file path/to/your/file.java