Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding class for generating all subsequences from a given List #5194

Merged
merged 16 commits into from
May 30, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented May 29, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.69%. Comparing base (a6e873d) to head (d4b69df).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5194      +/-   ##
============================================
+ Coverage     38.63%   38.69%   +0.05%     
- Complexity     2379     2383       +4     
============================================
  Files           516      517       +1     
  Lines         15388    15403      +15     
  Branches       2957     2958       +1     
============================================
+ Hits           5945     5960      +15     
  Misses         9158     9158              
  Partials        285      285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02
Copy link
Member

vil02 commented May 29, 2024

Is there a difference between ArrayCombination (currently under heavy refactoring in #5181) and your code? (There is an obvious difference)

I like the fact that your code is generic.

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I made few renaming suggestions.

alxkm added 2 commits May 30, 2024 16:14
Renaming test method.
Adding duplication test.
Renaming TestData to TestCase.
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Dzięki!

@vil02 vil02 enabled auto-merge (squash) May 30, 2024 18:42
@vil02 vil02 merged commit 2568b96 into TheAlgorithms:master May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants