Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1666: Remove duplicate entry of Sieve of Eratosthenes #1712

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ApeSkillx
Copy link

@ApeSkillx ApeSkillx commented Oct 5, 2024

Fixes Issue #1666

  • Removed the SieveOfEratosthenes.js file, which contained the boolean array implementation.
  • Renamed SieveOfEratosthenesIntArray.js to SieveOfEratosthenes.js to maintain a cleaner and clearer implementation.
  • Consolidated and updated the tests to reflect the changes.

All tests pass locally.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get rid of the unrelated changes to MobiusFunction.js, package-lock.json and package.json. Otherwise this looks fine.

@ApeSkillx
Copy link
Author

Please get rid of the unrelated changes to MobiusFunction.js, package-lock.json and package.json. Otherwise this looks fine.

@appgurueu
Fixed it. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants