-
-
Notifications
You must be signed in to change notification settings - Fork 45.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/consolidated reverse letters and reverse long words #10107
Closed
AnshuSharma111
wants to merge
4
commits into
TheAlgorithms:master
from
AnshuSharma111:fix/consolidated-reverse_letters-and-reverse-long-words
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bc99983
deleted reverse_long_words.py and modified code of reverse_letters.py…
AnshuSharma111 b0f8311
Deleted reverse_long_words.py and modified code of reverse_letters.py…
AnshuSharma111 66f3f9d
Added missing parameter to function
AnshuSharma111 2a6d45d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,22 @@ | ||
def reverse_letters(input_str: str) -> str: | ||
def reverse_letters(sentence: str, length: int) -> str: | ||
""" | ||
Reverses letters in a given string without adjusting the position of the words | ||
>>> reverse_letters('The cat in the hat') | ||
'ehT tac ni eht tah' | ||
>>> reverse_letters('The quick brown fox jumped over the lazy dog.') | ||
'ehT kciuq nworb xof depmuj revo eht yzal .god' | ||
>>> reverse_letters('Is this true?') | ||
'sI siht ?eurt' | ||
>>> reverse_letters("I love Python") | ||
'I evol nohtyP' | ||
Reverse all words that are longer than the given length of characters in a sentence. | ||
|
||
>>> reverse_letters("Hey wollef sroirraw", 3) | ||
'Hey fellow warriors' | ||
>>> reverse_letters("nohtyP is nohtyP", 2) | ||
'Python is Python' | ||
>>> reverse_letters("1 12 123 1234 54321 654321", 5) | ||
'1 12 123 1234 54321 123456' | ||
""" | ||
return " ".join([word[::-1] for word in input_str.split()]) | ||
return " ".join( | ||
"".join(word[::-1]) if len(word) > length else word for word in sentence.split() | ||
) | ||
|
||
|
||
if __name__ == "__main__": | ||
import doctest | ||
|
||
doctest.testmod() | ||
|
||
print(reverse_letters("Hey wollef sroirraw", 3)) |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the length an optional parameter so that we can still preserve the same functionality as the original
reverse_letters
Please also add a test case for
length = 0