Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidated two scripts reverse_letters.py and reverse_long_words.py into one #10140

Merged
merged 5 commits into from
Oct 8, 2023
Merged

Consolidated two scripts reverse_letters.py and reverse_long_words.py into one #10140

merged 5 commits into from
Oct 8, 2023

Conversation

AnshuSharma111
Copy link
Contributor

Consolidated two scripts reverse_letters.py and reverse_long_words.py into one because of similar functionality

Describe your change:

  1. Deleted reverse_long_words.py
  2. Modified code of reverse_letters.py to accommodate functionality of the above script
  3. Changed DIRECTORY to fit the changes

Fixes #8098

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 8, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 8, 2023
@ChrisO345 ChrisO345 merged commit 66e4ea6 into TheAlgorithms:master Oct 8, 2023
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 8, 2023
@AnshuSharma111 AnshuSharma111 deleted the fix/consolidated-reverse-letters-scripts-into-one branch October 9, 2023 03:46
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@AnshuSharma111 @sedatguzelsemme
Consolidated two scripts reverse_letters.py and reverse_long_words.py…
22bfc1a 
… into one (TheAlgorithms#10140)

* Conolidated two scripts reverse_letters.py and reverse_long_words.py into one because of similar functionality

* Added a new line to accomodate characters without going over 88 char limit

* fixed grammar to pass pre-commit

* Changed faulty test case entirely to pass pre commit

* fixed a test case which was wrong

---------

Co-authored-by: Keyboard-1 <142900182+Keyboard-1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisO345 ChrisO345 ChrisO345 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concatenate/consolidate all algorithms with different implementations
2 participants
@AnshuSharma111 @ChrisO345