Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate bubble sort iterative and recursive #10651

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Consolidate bubble sort iterative and recursive #10651

merged 5 commits into from
Oct 19, 2023

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Oct 17, 2023 •
edited
Loading

Describe your change:

Ref #8098

Merge recursive_bubble_sort with bubble_sort, renaming functions to bubble_sort_recursive and bubble_sort_iterative, respectively.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Merge two different implementations of same algorithm into one file

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

cclauss
cclauss reviewed Oct 17, 2023
View reviewed changes
sorts/bubble_sort.py Outdated Show resolved Hide resolved
cclauss
cclauss requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix function signature to be similar.
  2. Add a timeit benchmark to prove the relative performance.
  1. Doctests should cover similar (or identical) test cases across both functions.

@algorithms-keeper algorithms-keeper bot added the awaiting changes A maintainer has requested changes to this PR label Oct 17, 2023
@R055A @cclauss
Update sorts/bubble_sort.py
1dacbec 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 17, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 17, 2023
@R055A R055A requested a review from cclauss October 17, 2023 19:52
@R055A
Copy link
Contributor Author

R055A commented Oct 18, 2023

  1. Fix function signature to be similar.

    1. Add a timeit benchmark to prove the relative performance.
    1. Doctests should cover similar (or identical) test cases across both functions.

Hi @cclauss to my understanding, the requested changes have been completed. Let me know what you think, please

@R055A R055A mentioned this pull request Oct 19, 2023
Merged
15 tasks
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 19, 2023
cclauss
cclauss approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bubble!!! Thanks for doing this.

Final edits: b37d3bb

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 19, 2023
@cclauss cclauss merged commit 9875f37 into TheAlgorithms:master Oct 19, 2023
3 checks passed
@R055A R055A deleted the consolidate-bubble-sort branch October 19, 2023 20:50
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@R055A @cclauss
@pre-commit-ci @sedatguzelsemme
Consolidate bubble sort iterative and recursive (TheAlgorithms#10651)
1a27f00 
* Consolidate bubble sort iterative and recursive

* Update sorts/bubble_sort.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Refactor bubble sort func signature, doctest, timer

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update bubble_sort.py

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@R055A @cclauss