Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create cached fibonacci algorithm #8084

Merged
merged 3 commits into from
Jan 7, 2023
Merged

Create cached fibonacci algorithm #8084

merged 3 commits into from
Jan 7, 2023

Conversation

CaedenPH
Copy link
Contributor

@CaedenPH CaedenPH commented Jan 7, 2023

Describe your change:

Links to #8083

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@CaedenPH
Copy link
Contributor Author

CaedenPH commented Jan 7, 2023

@cclauss if you like how this is implemented, we could implement it across many other recursive functions across the repository.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Jan 7, 2023
@cclauss
Copy link
Member

cclauss commented Jan 7, 2023

Please add the benchmark results to these comments so the reviewer has a sense of the improvement.

@CaedenPH
Copy link
Contributor Author

CaedenPH commented Jan 7, 2023

@cclauss Like this?

cclauss
cclauss approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. In future PRs you can put the benchmark results in the commit message because the numbers will change from machine to machine.

@cclauss cclauss merged commit 4939e84 into TheAlgorithms:master Jan 7, 2023
@algorithms-keeper algorithms-keeper bot removed awaiting reviews This PR is ready to be reviewed labels Jan 7, 2023
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@CaedenPH @pre-commit-ci @Cjkjvfnby
Create cached fibonacci algorithm (TheAlgorithms#8084)
7c234b2 
* feat: Add `fib_recursive_cached` func

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* doc: Show difference in time when caching algorithm

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaedenPH @cclauss