Concatenate algorithms #8103
Closed
Concatenate algorithms #8103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
enhancement
algorithms-keeper
bot
removed
the
tests are failing
|
@cclauss Review please? |
tianyizheng02
requested changes
Feb 6, 2023
| @@ -1,20 +1,78 @@ | |||
| """Binary Exponentiation.""" | |||
| def binary_exponentiation_multiplication(a, b): | |||
There was a problem hiding this comment.
It looks like this function calculates a * b rather than a ** b, so shouldn't it belong in a file like binary_multiplication.py instead?
| @@ -17,6 +17,74 @@ def bin_exp_mod(a, n, b): | |||
| return (r * r) % b | |||
|
|
|||
|
|
|||
| def binary_exponentiation_mod_multiplication(a, b, c): | |||
There was a problem hiding this comment.
This function also appears to calculate (modular) multiplication rather than exponentiation, so I feel like this might also belong better in a separate file for binary multiplication
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper
bot
added
merge conflicts
|
Where exactly are there merge conflicts? |
|
Not sure where the merge conflicts are, I'll probably reimplement this pull request fixing the conflicts |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
FIxes #8098
Checklist:
Fixes: #{$ISSUE_NO}.