-
-
Notifications
You must be signed in to change notification settings - Fork 45.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleted sorts/random_pivot_quick_sort.py. Fixes #9124 #9178
Conversation
Thanks for your contribution! |
Just realized that the implementation in |
Oh! My bad i didn't notice it. Are you going to open it? Or do you want me to do so. |
I'll open the PR. The deleted implementation needs much fixing anyway (no tests, no type hints, etc) |
Wait... I just took a look at the original |
Oh! Thats surprising. Opening another PR doing the same. I think i should take a look and report all those similar implementations in entire codebase as issues. As hacktoberfest has started some new comers will try to fix that issue as their |
I just opened a PR deleting the other file. We actually already have an issue addressing duplicate algorithms (#8098), and I just added the "good first issue" tag to the issue. Thanks for the suggestion |
I just saw that you also opened a PR regarding same. Sorry i didn't see it earlier. Thanks for considering my suggestion. |
Describe your change:
Fixes #9124.
Deleted sorts/random_pivot_quick_sort.py
Checklist: