Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed maths/miller_rabin.py , Double implementation. #8098 #9228

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Removed maths/miller_rabin.py , Double implementation. #8098 #9228

merged 5 commits into from
Oct 2, 2023

Conversation

aryan1165
Copy link
Contributor

@aryan1165 aryan1165 commented Oct 1, 2023 •
edited
Loading

Describe your change:

Fixes #8098.
Removed maths/miller_rabin.py as it is already there ciphers/rabin_miller.py.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 1, 2023
@aryan1165 aryan1165 changed the title Removed ciphers/rabin_miller.py , Double implementation. #8098 Removed maths/miller_rabin.py , Double implementation. #8098 Oct 1, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 1, 2023
@ChrisO345 ChrisO345 merged commit f8fe8fe into TheAlgorithms:master Oct 2, 2023
2 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 2, 2023
@aryan1165 aryan1165 deleted the rabin_miller.py branch October 2, 2023 23:10
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@aryan1165 @sedatguzelsemme
Removed maths/miller_rabin.py , Double implementation. TheAlgorithms#…
30f823f 
…8098 (TheAlgorithms#9228)

* Removed ciphers/rabin_miller.py as it is already there maths/miller_rabin.py

* Renamed miller_rabin.py to rabain_miller.py

* Restore ciphers/rabin_miller.py and removed maths/rabin_miller.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisO345 ChrisO345 ChrisO345 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concatenate/consolidate all algorithms with different implementations
2 participants
@aryan1165 @ChrisO345