Consolidate gamma #9769
Merged
Consolidate gamma #9769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
enhancement
tianyizheng02
requested changes
Oct 5, 2023
maths/gamma.py
Outdated
Comment on lines
104
to
110
| def test_gamma_recursive() -> None: | ||
| """ | ||
| >>> test_gamma_recursive() | ||
| """ | ||
| assert gamma_recursive(0.5) == math.sqrt(math.pi) | ||
| assert gamma_recursive(1) == 1.0 | ||
| assert gamma_recursive(2) == 1.0 |
There was a problem hiding this comment.
Could we get rid of this function by adding its tests to the gamma_recursive doctests?
There was a problem hiding this comment.
Yes, I just realized that 108 and 110 are already tested in the doctests
tianyizheng02
requested changes
Oct 6, 2023
tianyizheng02
approved these changes
Oct 6, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* refactor(gamma): Append _iterative to func name * refactor(gamma): Consolidate implementations * refactor(gamma): Redundant test function removal * Update maths/gamma.py --------- Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Consolidation of gamma and gamma_recursive into one file
Fixes #8098
Checklist: