Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tbbc_money.pair_history_manager service definition #181

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

hhamon
Copy link
Contributor

@hhamon hhamon commented Aug 26, 2024

No description provided.

@johanwilfer
Copy link
Collaborator

@hhamon Was this broken by the last PR (to make it optional with Doctorine if you use only MongoDB) or what is the background for this PR?

@hhamon
Copy link
Contributor Author

hhamon commented Aug 27, 2024

@johanwilfer after upgrading from 6.0.0 to 6.0.1, my CI fails:

> @php bin/console lint:container


 [ERROR] Invalid definition for service "tbbc_money.pair_history_manager":
         "Tbbc\MoneyBundle\PairHistory\PairHistoryManager::__construct()" requires 2 arguments, 1 passed.

@johanwilfer
Copy link
Collaborator

Yeah, this basically reverts #180

@mustanggb What do you suggest? Any way to make it optional for MongoDb users still or do we have to revert your change?

@mustanggb
Copy link
Contributor

I don't know how to denote that a service is optional, perhaps someone cleverer than me does.

However as this was a new addition anyway, we can just remove it, as per #182.

@hhamon
Copy link
Contributor Author

hhamon commented Aug 27, 2024

I think it must be resolved with a DI compiler pass

@johanwilfer
Copy link
Collaborator

For now I will merge this, to revert this until we resolved it properly.

@johanwilfer johanwilfer merged commit f5d13ce into TheBigBrainsCompany:master Aug 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants