Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tests for PHP 8.4 #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chris53897
Copy link
Contributor

No description provided.

@johanwilfer
Copy link
Collaborator

Any idea why the tests fail?

@Chris53897
Copy link
Contributor Author

psalm and moneyphp/money (because of psalm) do not support PHP 8.4 yet.

moneyphp/money#796

@Chris53897 Chris53897 closed this Nov 22, 2024
@Chris53897 Chris53897 reopened this Nov 22, 2024
@Chris53897
Copy link
Contributor Author

moneyphp/money does now support PHP 8.4.
I need to update the PR to not install Psalm on PHP 8.4.
Move to PHPStan oder wait until it is supported by vimeo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants