Fix code, add final variables where needed.

TheNewEconomy · Dec 15, 2021 · d809c48 · d809c48
1 parent 95559a6
commit d809c48
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/TNE/src/net/tnemc/core/common/currency/type/MixedType.java b/TNE/src/net/tnemc/core/common/currency/type/MixedType.java
@@ -77,12 +77,12 @@ public void setHoldings(UUID account, String world, TNECurrency currency, BigDec
     if(holdings.compareTo(BigDecimal.ZERO) != 0 && holdings.compareTo(amount) > 0) {
       final BigDecimal virtualHoldings = virtualHoldings(account, world, currency);
 
-      BigDecimal toSet = amount;
+      final boolean itemNeeded = (virtualHoldings.compareTo(amount) < 0);
 
-      if(virtualHoldings.compareTo(amount) < 0) {
-        final BigDecimal remaining = amount.subtract(virtualHoldings);
+      final BigDecimal toSet = (itemNeeded)? BigDecimal.ZERO : amount;
 
-        toSet = BigDecimal.ZERO;
+      if(itemNeeded) {
+        final BigDecimal remaining = amount.subtract(virtualHoldings);
 
         setItemHoldings(account, world, currency, itemHoldings(account, world, currency, false).subtract(remaining));
       }