Allow relocating media root #939
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When self hosting, I make backups of the data I cannot recreate-- a lesson I learned the hard way. Right now, all user files (eg. time lapses) are stored under the hardcoded path `<gitrepo>/backend/static_build/media` which is intermingled with the source. I want to back up the user files and database, but not the source (it's easy to re-clone it and recreate the containers). The database can already be redirected to a different file with an environment variable for expert users. This trivial change adds a similar MEDIA_ROOT env var for expert users so that all uploaded files can go to a different place if desired.
|
I thought I have commented on this PR but apparently I haven't... I think I understand why you want to make media root customizable. But do you think your problem can be solved by linking The reason why I proposed this alternative is it's not obvious to a lot of people that MEDIA_ROOT should be the path in the container, which is different from the one on the host. I feel that having this configurable will only confuse most self-hosted users, and result in a lot of questions about "why is my server failing now after I have changed MEDIA_ROOT?" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When self hosting, I make backups of the data I cannot recreate-- a lesson I learned the hard way. Right now, all user files (eg. time lapses) are stored under the hardcoded path
<gitrepo>/backend/static_build/mediawhich is intermingled with the source. I want to back up the user files and database, but not the source (it's easy to re-clone it and recreate the containers).The database can already be redirected to a different file with an environment variable for expert users. This trivial change adds a similar MEDIA_ROOT env var for expert users so that all uploaded files can go to a different place if desired.