all: Do not use connection state in peer call

CHANGELOG.md

@@ -39,6 +39,7 @@ For details about compatibility between different releases, see the **Commitment
 
 - Attempting to claim an end device with a generated DevEUI will now result in an error.
 - Claiming an end device using command line flags.
+- 24 hour stack components deadlock when the default clustering mode is used.
 
 ## [3.25.0] - 2023-04-05
 

cmd/ttn-lw-cli/internal/api/grpc.go

@@ -28,7 +28,6 @@ import (
 	"go.thethings.network/lorawan-stack/v3/pkg/rpcmiddleware/rpclog"
 	"go.thethings.network/lorawan-stack/v3/pkg/rpcmiddleware/rpcretry"
 	"google.golang.org/grpc"
-	"google.golang.org/grpc/connectivity"
 	"google.golang.org/grpc/credentials"
 )
 
@@ -184,7 +183,7 @@ func CloseAll() {
 	defer connMu.Unlock()
 	for target, conn := range conns {
 		delete(conns, target)
-		if conn == nil || conn.GetState() == connectivity.Shutdown {
+		if conn == nil {
 			continue
 		}
 		conn.Close()

pkg/cluster/cluster.go

@@ -27,7 +27,6 @@ import (
 	"go.thethings.network/lorawan-stack/v3/pkg/random"
 	"go.thethings.network/lorawan-stack/v3/pkg/ttnpb"
 	"google.golang.org/grpc"
-	"google.golang.org/grpc/connectivity"
 	"google.golang.org/grpc/credentials"
 )
 
@@ -317,18 +316,16 @@ func (c *cluster) Leave() error {
 }
 
 func (c *cluster) GetPeers(ctx context.Context, role ttnpb.ClusterRole) ([]Peer, error) {
-	var matches []Peer
+	matches := make([]Peer, 0, len(c.peers))
 	for _, peer := range c.peers {
 		if !peer.HasRole(role) {
 			continue
 		}
-		conn, err := peer.Conn()
+		_, err := peer.Conn()
 		if err != nil {
 			continue
 		}
-		if conn.GetState() == connectivity.Ready {
-			matches = append(matches, peer)
-		}
+		matches = append(matches, peer)
 	}
 	return matches, nil
 }