console: Fix desired rx1 settings

TheThingsNetwork · Feb 14, 2023 · b62fc3e · b62fc3e
1 parent b14ae59
commit b62fc3e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,7 @@ For details about compatibility between different releases, see the **Commitment
 ### Fixed
 
 - Key unwrap caching.
+- Desired RX1 delay and desired beacon frequency not being possible to set for OTAA devices.
 
 ### Security
 

diff --git a/pkg/webui/console/components/mac-settings-section/index.js b/pkg/webui/console/components/mac-settings-section/index.js
@@ -150,7 +150,7 @@ const MacSettingsSection = props => {
   const [isCollapsed, setIsCollapsed] = React.useState(initiallyCollapsed)
   const handleIsCollapsedChange = React.useCallback(() => {
     if (!isCollapsed && pingPeriodicityRequired) {
-      // Do not close section if `ping_slot_perdiodicity` is required.
+      // Do not close section if `ping_slot_periodicity` is required.
       return
     }
 

diff --git a/pkg/webui/console/views/device-general-settings/network-server-form/validation-schema.js b/pkg/webui/console/views/device-general-settings/network-server-form/validation-schema.js
@@ -146,7 +146,7 @@ const validationSchema = Yup.object()
             )
           }),
           desired_beacon_frequency: Yup.lazy(() => {
-            if (!isClassB || mode !== ACTIVATION_MODES.MULTICAST) {
+            if (!isClassB || mode === ACTIVATION_MODES.MULTICAST) {
               return Yup.number().strip()
             }
 
@@ -180,7 +180,7 @@ const validationSchema = Yup.object()
               .max(15, Yup.passValues(sharedMessages.validateNumberLte))
           }),
           desired_rx1_delay: Yup.lazy(delay => {
-            if (delay === undefined || delay === '' || mode !== ACTIVATION_MODES.MULTICAST) {
+            if (delay === undefined || delay === '' || mode === ACTIVATION_MODES.MULTICAST) {
               return Yup.number().strip()
             }