Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 encoding during compilation #186

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blazekd
Copy link

@blazekd blazekd commented Jul 11, 2023

Force use of UTF-8 encoding during compilation in build-jar.sh. Couldn't compile without that because my system uses windows-1250 encoding and there were some unmappable characters. javac by default uses system encoding and windows doesn't use UTF-8 as default.

I also added UTF-8 encoding in test.sh for consistency. Also edited javac command in test.sh to work in MinGW and Cygwin - windows uses ; for seperating classpaths instead of :.

@blazekd blazekd changed the title Encoding fix Use UTF-8 encoding during compilation Jul 11, 2023
@TheThirdOne
Copy link
Owner

Is there a reason to include a if statement? Both formulations work on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants