Memory Changes (second edition) #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alternative assembler could be made that returns a list of statements and list of datastructs. Maybe space should allocate a 0 length write at the start and endto make sure that that gets included in the total length of the data section. That would allow generating an elf file and therefore allow more compatability testing.
Also removed util.MemoryDump and changed memory configurations significantly This is now compiling and passing automated tests, but doesn't have correct GUI behaviour.
The problem with the addresss selector was that it used signed comparisons rather than unsigned. I moved the setting of the saved configuration into settings rather than memoryconfiguration because it prevents circular static dependency issues. The memory configuration setter now shows ranges for the various segments. Config files for memory configurations are now property files. I will put an example of on the wiki.
Because the limits on the size of segments weren't recalculated with respect to the blocks of memory, it was possible to cause an uncaught exception. That should no longer be possible.
It was a stretch to call it .bss and I was thinking about removing it entirely. So I think sticking with what is was previously called is better.
One issue is that if no arguments were passed, the stack pointer could be pointing outside the stack. 2b15af6 removed the 4K buffer to the top of the stack, so this bug showed up now. Similarly it would caused an internal error when run with arguments because it would try to write to the byte just above the stack. Additionally, I changed the GUI to actually set the arguments for blank arguments so you get the desired stack (argc=0,argv={0}) Finally, I cleaned up a little
|
Some potential correctness tests:
|
|
TODOS:
Things to consider for the future:
|
|
Will data segment window show doublewords (64 bits), instead of words, in 64-bit mode? It would be great if there is an option to select data sizes (byte, half words, words, doublewords). |
|
@zhijieshi, this PR is almost exclusively about the internals of RARS. Changes to the UI of the data view would be beyond the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was #71.
I making this to give me an easy way to review all the changes I make and make any comments that may be useful for future me.