Feat/#178: 유저 기권 및 관리자가 실격처리 할 수 있도록 추가 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navyjeongs
reviewed
Oct 19, 2023
Comment on lines
52
to
56
| {requestUser === -1 && ( | ||
| <DisqualificationButton onClick={() => onClickDisqualification(player)}> | ||
| 실격처리 | ||
| </DisqualificationButton> | ||
| )} |
There was a problem hiding this comment.
실격처리 Text가 나타나면 list의 정렬이 깨져보이는데 이미 실격된 유저들에게도 div 태그를 추가하거나 아니면 실격 처리 버튼의 position을 absolute로 해도 괜찮을 것 같아요
수정 완료했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤠 개요
💫 설명
현재 실격 및 기권 확인은 소켓을 사용한 통신이 아니기에 실시간으로 확인할 수 없어요. 그렇기에 이에 대해 논의 해봐야해요
마찬가지로 실격된 유저의 경우 현재 등수는 어떻게 되고 어디에 배치가 될건지 의논해봐야해요
📷 스크린샷 (Optional)
--- 수정 후 스크린샷
