Feat/#285 로그인 확인 미들웨어 작성 및 로그인 페이지 변경 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤠 개요
미들 웨어를 만들고 Provider 위치를 옮기고 로그인 페이지를 변경했어요.
💫 설명
기존에는 프로필을 api를 요청하고 api 성공 여부에 따라 로그인여부를 판별했는데 토큰이 없으면 반드시 실패하는 불필요한 api 요청이라고 생각해 미들웨어에서 액세스토큰 여부에따라 로그인 여부를 판별했어요. 그리고 인해 로그인했을 때만 channel을 불러와 기존에 _app에서 채널, 프로필 Provider를 layout 내부로 옮겼어요.
관련 정리 바로가기
그로인해 로그인을 하지 않으면 기존에 /에서 로그인 컴포넌트를 보여줬는데 /login으로 이동해 로그인 페이지를 보여주도록 변경했어요!
📷 스크린샷 (Optional)