Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading and writing data larger than shared buffer to EEPROM #18

Merged

Conversation

garethpotter
Copy link
Collaborator

@garethpotter garethpotter commented Feb 17, 2024

This allows data larger than the shared buffer size to be loaded from/saved to EEPROM. The only requirement is that the buffer be large enough to hold the largest single key-value pair in the stored data (i.e. it cannot loads part of an array over separate reads).

@garethpotter garethpotter force-pushed the eeprom-progressive-import-export branch 5 times, most recently from f2e39b9 to 2aa0e17 Compare February 18, 2024 07:49
@garethpotter garethpotter marked this pull request as ready for review February 18, 2024 11:56
@garethpotter garethpotter force-pushed the eeprom-progressive-import-export branch 2 times, most recently from b47489d to 1a30a81 Compare February 18, 2024 16:16
@garethpotter garethpotter force-pushed the eeprom-progressive-import-export branch 5 times, most recently from 5a6a6e2 to 374fb74 Compare March 6, 2024 16:00
@garethpotter garethpotter force-pushed the eeprom-progressive-import-export branch 2 times, most recently from 792d3ee to f754e38 Compare March 22, 2024 16:20
@garethpotter garethpotter force-pushed the eeprom-progressive-import-export branch from f754e38 to 031e652 Compare March 22, 2024 16:24
Copy link
Contributor

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, only some minor things.

west.yml Outdated Show resolved Hide resolved
src/storage_eeprom.c Outdated Show resolved Hide resolved
src/storage_eeprom.c Outdated Show resolved Hide resolved
src/storage_eeprom.c Outdated Show resolved Hide resolved
src/storage_eeprom.c Outdated Show resolved Hide resolved
src/storage_eeprom.c Outdated Show resolved Hide resolved
@martinjaeger
Copy link
Contributor

Ah, please add a description to the PR.

Copy link
Contributor

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more change request I didn't spot last time.

Can you also please add this configuration to the testcase.yml so that it is tested in CI?

src/Kconfig.can Outdated Show resolved Hide resolved
@martinjaeger martinjaeger merged commit bd8d916 into ThingSet:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants