-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reading and writing data larger than shared buffer to EEPROM #18
Support reading and writing data larger than shared buffer to EEPROM #18
Conversation
f2e39b9
to
2aa0e17
Compare
b47489d
to
1a30a81
Compare
5a6a6e2
to
374fb74
Compare
792d3ee
to
f754e38
Compare
f754e38
to
031e652
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, only some minor things.
Ah, please add a description to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one more change request I didn't spot last time.
Can you also please add this configuration to the testcase.yml
so that it is tested in CI?
This allows data larger than the shared buffer size to be loaded from/saved to EEPROM. The only requirement is that the buffer be large enough to hold the largest single key-value pair in the stored data (i.e. it cannot loads part of an array over separate reads).