Mw/cache no fail #49
Merged
Mw/cache no fail #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R2ZER0
reviewed
Sep 21, 2023
Make cache exceptions non fatal If the cache fails for whatever reason then carry on without it. We generally don't want cache errors to be fatal but they are useful to know about so we just print the exceptions which will get picked up by the monitoring. Fixes: #48
michaelwood
force-pushed
the
mw/cache_no_fail
branch
from
384d1cd to
7b710d8
Compare
R2ZER0
approved these changes
Oct 2, 2023
|
Now deployed thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the cache mechanism more robust and avoids errors being fatal. Fixes #48