requirements: Unpin very old importlib-metadata #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear that importlib-metadata needs to be pinned in `requirements.in`, as it's a core package we don't use directly. This pin of a very old version is causing issues with trying to use newer versions of libraries in TSG/datastore. It appears that no other ODSC or TSG project pins this package in their `requirements.in` files, so I think this unpin should be safe.
michaelwood
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear that importlib-metadata needs to be pinned in
requirements.in, as it's a core package we don't use directly. This pin of a very old version is causing issues with trying to use newer versions of libraries in TSG/datastore.It appears that no other ODSC or TSG project pins this package in their
requirements.infiles, so I think this unpin should be safe.From searching in the projects:
https://github.com/search?q=org%3AThreeSixtyGiving+importlib-metadata&type=code
https://github.com/search?q=org%3AOpenDataServices+importlib-metadata&type=code