Set Pixmap depths after creating visuals

This affects the ordering of visuals, which breaks some buggy applications that assume the first visual is the root window visual.
TigerVNC · Jan 10, 2024 · 7ad74d1 · 7ad74d1 · DocMAX · Jan 10, 2024
1 parent a9ac7ae
commit 7ad74d1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/unix/xserver/hw/vnc/xvnc.c b/unix/xserver/hw/vnc/xvnc.c
@@ -992,8 +992,6 @@ vncScreenInit(ScreenPtr pScreen, int argc, char **argv)
     vncFbptr[0] = pbits;
     vncFbstride[0] = vncScreenInfo.fb.paddedWidth;
 
-    miSetPixmapDepths();
-
     switch (vncScreenInfo.fb.depth) {
     case 16:
         miSetVisualTypesAndMasks(16,
@@ -1018,6 +1016,8 @@ vncScreenInit(ScreenPtr pScreen, int argc, char **argv)
         return FALSE;
     }
 
+    miSetPixmapDepths();
+
     ret = fbScreenInit(pScreen, pbits,
                        vncScreenInfo.fb.width, vncScreenInfo.fb.height,
                        dpi, dpi, vncScreenInfo.fb.paddedWidth,